Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored buildMetadata of the plugins #375

Merged
merged 12 commits into from
May 22, 2023
Merged

Refactored buildMetadata of the plugins #375

merged 12 commits into from
May 22, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented May 15, 2023 •
edited by jira bot
Loading

Description

Task: OS-415

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@heueristik heueristik changed the title feat: refactored buildMetadata of the plugins Refactored buildMetadata of the plugins May 15, 2023
brickpop
brickpop reviewed May 15, 2023
View reviewed changes
packages/contracts/src/plugins/governance/admin/build-metadata.json Outdated Show resolved Hide resolved
packages/contracts/src/plugins/governance/admin/build-metadata.json Outdated Show resolved Hide resolved
packages/contracts/src/plugins/governance/admin/build-metadata.json Outdated Show resolved Hide resolved
packages/contracts/src/plugins/governance/admin/build-metadata.json Outdated Show resolved Hide resolved
packages/contracts/src/plugins/governance/majority-voting/addresslist/build-metadata.json Outdated Show resolved Hide resolved
packages/contracts/src/plugins/governance/majority-voting/token/build-metadata.json Show resolved Hide resolved
packages/contracts/src/plugins/governance/majority-voting/token/build-metadata.json Show resolved Hide resolved
packages/contracts/src/plugins/governance/majority-voting/token/build-metadata.json Show resolved Hide resolved
packages/contracts/src/plugins/governance/majority-voting/token/build-metadata.json Show resolved Hide resolved
packages/contracts/src/plugins/governance/majority-voting/token/build-metadata.json Outdated Show resolved Hide resolved
heueristik added a commit that referenced this pull request May 15, 2023
@heueristik
revert: metadata changes as they will happen in #375
8b51d4b
heueristik added a commit that referenced this pull request May 19, 2023
@heueristik @Rekard0 @brickpop
Fix ProposalCreated event dates (#369)
0ddff1b 
* feat: protect the DAO executor against reentrancy

* fix: remove console.log

* fix: prevent storage corruption

* feat: refactored reentrancy guard into a modifier

* feat: added tests and preliminary versioning

* chore: cleaning

* fix: remove empty comment

* fix: refactor findEventTopicLog function

* fix: moved implementation slot and renamed file

* fix: remove redundant includes

* prepare package

* remember the branch

* only artifact src

* correct the paths

* correct root path

* update hashes

* add logs

* only copy typechain

* generate typechain

* setup rollup

* update npm packages

* update rollup index

* add esm cjs

* add readme

* remove gitIgnore

* update typechain

* update typescript

* convert script to typescript

* change commit hash json

* rename types to typechain

* add test

* add json to rollup and export types

* update usage test

* generate index.ts dynamically

* update readme

* add empty line

* update commit hashes

* fix index.ts

* chore: update test

* fix: removed redundant imports

* chore: remove legacy version files of DAO

* fix: adapt contracts-version tests

* fix: remove version in title as contracts will get a constant

* fix: compile legacy contracts for regression testing

* Revert "fix: compile legacy contracts for regression testing "

This reverts commit 403436c.

* revert versioning changes

* adapt tests

* test with creating symbolic link

* correct path

* feat: added tests for proposal start and end date handling

* fix: corrected wrong validation order

* Revert "chore: remove legacy version files of DAO"

This reverts commit 57f755c.

* add legacy versions

* fix: renaming of the versions

* chore: remove old CI task

* chore: maintained changelog

* fix: version numbers

* fix: imports

* WIP

* doc: clarified the origin of the implementation slot

* fix: versioning

* fix: move files

* Apply suggestions from code review

Co-authored-by: Jør∂¡ <[email protected]>

* chore: formatting

* chore: remove NatSpec version number from osx files

* feat: added more tests

* Applied review suggestion

Co-authored-by: Rekard0 <[email protected]>

* feat: added test checking that execution is still possible after the upgrade

* Improved comments

* feat: initialize _rentrancyStatus

* doc: clarify comments

* fix: change version number

* fix: use upgradeToAndCall and correct versions

* feat: added initializeUpgradeFrom function and tests

* feat: improved function and added more tests

* WIP

* fix: tests

* fix: finalize tests

* fix typechain and add a script

* fix: typo

* feat: improve initializeUpgradeFrom

* feat: added _initData parameter

* feat: added test

* fix: wrong version number

* WIP

* fix remaining tests

* fix subgraph

* add ref depth

* fix: replacing getContractFactory and getContractAt by typechain factory calls  and added missing awaits

* fix: test timings

* fix: re-introduced yarn postinstall

* fix: remove redundant includes

* fix: adapt upgrade tests

* feat: optimize if statements

* fix: tests

* feat: rename initializeUpgradeFrom to initializeFrom

* fix: correct test description

* fix: removed duplicate file

* fix: typo

* fix: delete legacy files

* revert: metadata changes as they will happen in #375

* fix: merge conflicts

* fix: re-order changelog entries

* fix: remove wrong/redundant import originating from merge

* feat: improve upgrade version checks

* fix: remove redundant ROOT_PERMISSION grant call

* feat: added more checks to the upgrade tests

* feat: more explicit variable naming

* fix: reworked initializeFrom logic

* feat: improved changelog entry

* feat: improved comment

* chore: remove deploy scripts to be handled in a separate task

---------

Co-authored-by: Rekard0 <[email protected]>
Co-authored-by: Jør∂¡ <[email protected]>
brickpop
brickpop previously approved these changes May 22, 2023
View reviewed changes
@heueristik heueristik merged commit 724306e into develop May 22, 2023
@heueristik heueristik deleted the feature/OS-415-build-metadata-refactoring branch May 22, 2023 15:14
heueristik added a commit that referenced this pull request May 24, 2023
@heueristik @Rekard0 @brickpop
Deploy script for the protocol and plugin upgrades (#384)
43a5f39 
* feat: protect the DAO executor against reentrancy

* fix: remove console.log

* fix: prevent storage corruption

* feat: refactored reentrancy guard into a modifier

* feat: added tests and preliminary versioning

* chore: cleaning

* fix: remove empty comment

* fix: refactor findEventTopicLog function

* fix: moved implementation slot and renamed file

* fix: remove redundant includes

* prepare package

* remember the branch

* only artifact src

* correct the paths

* correct root path

* update hashes

* add logs

* only copy typechain

* generate typechain

* setup rollup

* update npm packages

* update rollup index

* add esm cjs

* add readme

* remove gitIgnore

* update typechain

* update typescript

* convert script to typescript

* change commit hash json

* rename types to typechain

* add test

* add json to rollup and export types

* update usage test

* generate index.ts dynamically

* update readme

* add empty line

* update commit hashes

* fix index.ts

* chore: update test

* fix: removed redundant imports

* chore: remove legacy version files of DAO

* fix: adapt contracts-version tests

* fix: remove version in title as contracts will get a constant

* fix: compile legacy contracts for regression testing

* Revert "fix: compile legacy contracts for regression testing "

This reverts commit 403436c.

* revert versioning changes

* adapt tests

* test with creating symbolic link

* correct path

* feat: added tests for proposal start and end date handling

* fix: corrected wrong validation order

* Revert "chore: remove legacy version files of DAO"

This reverts commit 57f755c.

* add legacy versions

* fix: renaming of the versions

* chore: remove old CI task

* chore: maintained changelog

* fix: version numbers

* fix: imports

* WIP

* doc: clarified the origin of the implementation slot

* fix: versioning

* fix: move files

* Apply suggestions from code review

Co-authored-by: Jør∂¡ <[email protected]>

* chore: formatting

* chore: remove NatSpec version number from osx files

* feat: added more tests

* Applied review suggestion

Co-authored-by: Rekard0 <[email protected]>

* feat: added test checking that execution is still possible after the upgrade

* Improved comments

* feat: initialize _rentrancyStatus

* doc: clarify comments

* fix: change version number

* fix: use upgradeToAndCall and correct versions

* feat: added initializeUpgradeFrom function and tests

* feat: improved function and added more tests

* WIP

* fix: tests

* fix: finalize tests

* fix typechain and add a script

* fix: typo

* feat: improve initializeUpgradeFrom

* feat: added _initData parameter

* feat: added test

* fix: wrong version number

* WIP

* fix remaining tests

* fix subgraph

* add ref depth

* fix: replacing getContractFactory and getContractAt by typechain factory calls  and added missing awaits

* fix: test timings

* fix: re-introduced yarn postinstall

* fix: remove redundant includes

* fix: adapt upgrade tests

* feat: optimize if statements

* fix: tests

* feat: rename initializeUpgradeFrom to initializeFrom

* fix: correct test description

* fix: removed duplicate file

* fix: typo

* fix: delete legacy files

* revert: metadata changes as they will happen in #375

* fix: merge conflicts

* fix: re-order changelog entries

* fix: remove wrong/redundant import originating from merge

* feat: improve upgrade version checks

* fix: remove redundant ROOT_PERMISSION grant call

* feat: added more checks to the upgrade tests

* feat: more explicit variable naming

* fix: reworked initializeFrom logic

* feat: improved changelog entry

* feat: improved comment

* fix: use factories

* feat: added deploy scripts

* fix: use the correct deployment method

* chore: remove the old, unused script for the v1.2.0 update

* fix: use deploy method


fix: use deploy method

* fix: file name

* feat: improve scripts by adding a TARGET_RELEASE variable

* fix: file name

* fix: wrong interface

* fix: import order

---------

Co-authored-by: Rekard0 <[email protected]>
Co-authored-by: Jør∂¡ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarinas josemarinas josemarinas approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

@brickpop brickpop brickpop left review comments

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heueristik @brickpop @Rekard0 @josemarinas