-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy script for the protocol and plugin upgrades #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eentrant-executor
fix: use deploy method
heueristik
force-pushed
the
feature/OS-416-deploy-script
branch
from
May 22, 2023 12:41
2b03726
to
0129db0
Compare
12 tasks
brickpop
reviewed
May 24, 2023
packages/contracts/deploy/update/to_v1.3.0/20_TokenVoting_Plugin.ts
Outdated
Show resolved
Hide resolved
packages/contracts/deploy/update/to_v1.3.0/30_AddresslistVoting_Plugin.ts
Outdated
Show resolved
Hide resolved
brickpop
previously approved these changes
May 24, 2023
Rekard0
reviewed
May 24, 2023
Rekard0
reviewed
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could u add a tag to all files, expressing the update
something like update_to_1_3_0
or what ever tag u prefer
brickpop
approved these changes
May 24, 2023
Rekard0
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note, that @mathewmeconry tested the previous deploy scripts with tenderly and that tests are worked on by @Rekard0 in Task OS-441.
Task: OS-416
Type of change