Payroll: Fix exchange rates request call #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izqui
approved these changes
Apr 16, 2019
facuspagnuolo
force-pushed
the
fix_price_feed_usage
branch
2 times, most recently
from
0cc1144 to
34159e1
Compare
sohkai
approved these changes
Apr 16, 2019
facuspagnuolo
force-pushed
the
fix_price_feed_usage
branch
from
34159e1 to
1d4edab
Compare
|
@sohkai after changing the way we were mocking PPF, many tests started failing since they were expecting different payout amounts due to the wrong rates, fixing the contract fixed those as well :) |
|
Haha that sounds reasonable 👍. |
facuspagnuolo
force-pushed
the
fix_price_feed_usage
branch
from
1d4edab to
b7bec0b
Compare
facuspagnuolo
force-pushed
the
fix_price_feed_usage
branch
from
b7bec0b to
3199767
Compare
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #792
Tests won't pass until we have a new version of PPF released including aragon/ppf#19, aragon/ppf#20, aragon/ppf#21, aragon/ppf#22, and aragon/ppf#23 changes