Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payroll: denomination token should be passed as the 'quote' to PPF #792

Closed
izqui opened this issue Apr 15, 2019 · 2 comments · Fixed by #797
Closed

Payroll: denomination token should be passed as the 'quote' to PPF #792

izqui opened this issue Apr 15, 2019 · 2 comments · Fixed by #797
Assignees
@facuspagnuolo
Labels
component: contract

Comments

@izqui
Copy link
Contributor

izqui commented Apr 15, 2019

The denomination token should always be the quote and the base should be the token that we are asking the price for (see PPF.get).

This is currently swapped in the Payroll contract so the rates will be inverted.
@luisivan luisivan mentioned this issue Apr 15, 2019
Closed
29 tasks
@sohkai
Copy link
Contributor

sohkai commented Apr 15, 2019

This is probably something our tests should have caught early on 😅

@facuspagnuolo
Copy link
Contributor

facuspagnuolo commented Apr 15, 2019 •
edited
Loading

Yep, unfortunately, rates were mocked for a long time

@facuspagnuolo facuspagnuolo self-assigned this Apr 15, 2019
@facuspagnuolo facuspagnuolo mentioned this issue Apr 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facuspagnuolo facuspagnuolo

Labels
component: contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Payroll: Fix exchange rates request call aragon/aragon-apps
3 participants
@izqui @sohkai @facuspagnuolo