Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy improvements #795

Merged
merged 5 commits into from
Apr 17, 2019
Merged

Copy improvements #795

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c0d572
Copy improvements
luisivan Apr 15, 2019
8599e51
Merged with master
luisivan Apr 16, 2019
51c8824
More specific copy
luisivan Apr 16, 2019
75b68c9
Merge branch 'master' into copies-0.7-luis
luisivan Apr 17, 2019
c36a8a7
Reverting change
luisivan Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/voting/app/src/components/VotePanelContent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ const VotePanelContent = React.memo(
</div>
<div>
<h2>
<Label>Quorum progress</Label>
<Label>Total yes votes</Label>
Copy link
Contributor

@john-light john-light Apr 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Total yes votes really captures what is being shown (which is a % anyways)

Screenshot_2019-04-15 Aragon

Users have to know what min. quorum is to have intelligent conversations about a vote e.g.
Alice: "Why didn't this vote pass even though it has more yes than no votes?"
Bob: "The minimum quorum threshold wasn't reached."

I would actually change it to Min. Quorum progress since this is how we refer to it in onboarding and the user guide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think quorum is a very technical term, and even I get really confused by it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luisivan then it could be explained, maybe with a tooltip next to the term. This is how it is explained in the User Guide:

“Min. Quorum” is short for “Minimum Acceptance Quorum". Min. Quorum is the number for what percent of the total outstanding supply of tokens must approve a proposal for the vote to be considered valid. For example, if the Min. Quorum is set to 20%, then 20% of the outstanding token supply must vote to approve a proposal for the vote to be considered valid. If a vote does not make quorum, then it will fail, even if more tokens voted to approve the proposal than voted against it. For example, if the Min. Quorum is set to 20% and 10% of the outstanding token supply votes against the proposal but only 15% vote in support, then the proposal will fail because it has not reached the Min. Quorum threshold.

Copy link

@dizzypaty dizzypaty Apr 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luisivan @john-light Last week I had a chat with @lkngtn about Aragon's quorum and how it differs from conventional quorum with the aim of adding clarity to the product on-boarding. He suggested that we could rename 'Quorum' as ‘Minimum approval %’ because it’s more accurate. I personally like it because it might be easier to understand by people that are confused by the definition of quorum in general, and because it's more precise as to how we use it.

I agree with John's idea, we should also offer further details/explanation by using a info popover or tooltip and should be consistent with the ones presented on the product on-boarding redesign.

cc @bpierre @sohkai

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retracted this change for now, proceeding to merge and will come back to the quorum term in the future

</h2>
<div>
{round(quorumProgress * 100, 2)}%{' '}
Expand Down
3 changes: 2 additions & 1 deletion apps/voting/app/src/components/VoteSuccess.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ const VoteSuccess = ({ vote, ...props }) => {
<Icon />
</IconWrapper>
<StatusLabel>
{success ? 'Vote will pass' : 'Vote won’t pass'}
Current outcome:
{success ? ' Yes' : ' No'}
</StatusLabel>
</React.Fragment>
)
Expand Down
4 changes: 2 additions & 2 deletions apps/voting/app/src/components/VoteSummary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ const VoteSummary = ({ vote, tokenSymbol, tokenDecimals, ready }) => {
<Header>
<span>
<Text color={theme.textSecondary} smallcaps>
Current support{' '}
Votes{' '}
luisivan marked this conversation as resolved.
Show resolved Hide resolved
</Text>
<Text size="xsmall" color={theme.textSecondary}>
({Math.round(supportRequired * 100)}% needed)
({Math.round(supportRequired * 100)}% support needed for approval)
</Text>
</span>
</Header>
Expand Down