-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy improvements #795
Copy improvements #795
Conversation
@luisivan This branch was created from quite an old commit (end of Feb); could you do a |
@@ -187,7 +187,7 @@ class VotePanelContent extends React.Component { | |||
</div> | |||
<div> | |||
<h2> | |||
<Label>Quorum progress</Label> | |||
<Label>Total yes votes</Label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Total yes votes
really captures what is being shown (which is a % anyways)
Users have to know what min. quorum is to have intelligent conversations about a vote e.g.
Alice: "Why didn't this vote pass even though it has more yes than no votes?"
Bob: "The minimum quorum threshold wasn't reached."
I would actually change it to Min. Quorum progress
since this is how we refer to it in onboarding and the user guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think quorum is a very technical term, and even I get really confused by it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luisivan then it could be explained, maybe with a tooltip next to the term. This is how it is explained in the User Guide:
“Min. Quorum” is short for “Minimum Acceptance Quorum". Min. Quorum is the number for what percent of the total outstanding supply of tokens must approve a proposal for the vote to be considered valid. For example, if the Min. Quorum is set to 20%, then 20% of the outstanding token supply must vote to approve a proposal for the vote to be considered valid. If a vote does not make quorum, then it will fail, even if more tokens voted to approve the proposal than voted against it. For example, if the Min. Quorum is set to 20% and 10% of the outstanding token supply votes against the proposal but only 15% vote in support, then the proposal will fail because it has not reached the Min. Quorum threshold.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luisivan @john-light Last week I had a chat with @lkngtn about Aragon's quorum and how it differs from conventional quorum with the aim of adding clarity to the product on-boarding. He suggested that we could rename 'Quorum' as ‘Minimum approval %’ because it’s more accurate. I personally like it because it might be easier to understand by people that are confused by the definition of quorum in general, and because it's more precise as to how we use it.
I agree with John's idea, we should also offer further details/explanation by using a info popover or tooltip and should be consistent with the ones presented on the product on-boarding redesign.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retracted this change for now, proceeding to merge and will come back to the quorum term in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments / suggestions.
* Copy improvements * More specific copy * Reverting controversial change
Mainly trying to clarify things for users and remove technical terms like quorum or execution