Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent: update help text #1169

Merged
merged 6 commits into from
Jun 25, 2020
Merged

Agent: update help text #1169

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
25383c7
Merge pull request #1 from aragon/master
ECWireless May 17, 2020
3e8f9b8
Agent: Update help text
ECWireless Jun 16, 2020
10dc39d
Revert to default Link color
ECWireless Jun 17, 2020
76bc0ff
Remove FrameModal.js and InstallFrame.js
ECWireless Jun 17, 2020
11f0dd3
AgentSvg: optimize
ECWireless Jun 17, 2020
21ecdff
AgentHelp: GU-ify svg dimensions
ECWireless Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/agent/app/src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { useAragonApi } from '@aragon/api-react'
import { Header, Main, SyncIndicator } from '@aragon/ui'
import Balances from './components/Balances'
import { IdentityProvider } from './components/IdentityManager/IdentityManager'
import InstallFrame from './components/InstallFrame'
import AgentHelp from './components/AgentHelp'
import Transactions from './components/Transactions'

function App() {
Expand Down Expand Up @@ -33,7 +33,7 @@ function App() {
>
<SyncIndicator visible={isSyncing} shift={50} />
<Header primary="Agent" />
<InstallFrame />
<AgentHelp />
<Balances balances={balances} />
<Transactions
agentAddress={proxyAddress}
Expand Down
54 changes: 54 additions & 0 deletions apps/agent/app/src/components/AgentHelp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
import React from 'react'
import { GU, Info, Link, useTheme } from '@aragon/ui'
import AgentSvg from './AgentSvg'

function AgentHelp() {
const theme = useTheme()

return (
<React.Fragment>
<Info
css={`
margin-bottom: ${2 * GU}px;
`}
>
<div
css={`
display: grid;
grid-template-rows: auto auto;
grid-template-columns: auto 1fr;
grid-column-gap: ${2 * GU}px;
align-items: center;
`}
>
<div
css={`
width: 46px;
height: 46px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a rule we avoid setting sizes with numbers, and always use the GU import with corresponds to 8 pixels, like this: width: ${6 * GU}px. This way we're more consistent. Let's GUify this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Done!

`}
>
<AgentSvg />
</div>
<div>
<div
css={`
margin-bottom: ${0.5 * GU}px;
`}
>
The Agent app can be used to interact with external contracts.
</div>
<div>
<Link
css={`
color: ${theme.indicatorContent};
`}
ECWireless marked this conversation as resolved.
Show resolved Hide resolved
href="https://help.aragon.org/article/37-agent">Learn More</Link>
</div>
</div>
</div>
</Info>
</React.Fragment>
)
}

export default AgentHelp
Loading