Agent: update help text #1169
Merged
Agent: update help text #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voting: update VoteText's address rendering (aragon#1146)
Evalir
reviewed
Jun 17, 2020
Let's remove them with this change as well :) |
sohkai
reviewed
Jun 17, 2020
- Also removes FrameSvg.js
Evalir
reviewed
Jun 23, 2020
Comment on lines
26
to
27
| width: 46px; | ||
| height: 46px; |
There was a problem hiding this comment.
As a rule we avoid setting sizes with numbers, and always use the GU import with corresponds to 8 pixels, like this: width: ${6 * GU}px. This way we're more consistent. Let's GUify this!
There was a problem hiding this comment.
Ah, I see. Done!
Evalir
approved these changes
Jun 25, 2020
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1162
@sohkai ended up leaving the InstallFrame.js component (and modal) in for now, but will delete if you don't think either are necessary to keep around.