Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secret): use only line with secret for long secret lines #7412

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Aug 28, 2024

Description

For long secret lines use only the line with the secret

before:

─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 j.txt:3
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   asd
   2   aaaa
   3 [ asd
aaaa
jwt: ***********************************************************************************************************************************************************

asda
   4   
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

after:

─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 j.txt:3
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   asd
   2   aaaa
   3 [ jwt: ***********************************************************************************************************************************************************
   4   
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Aug 28, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review August 28, 2024 03:41
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner August 28, 2024 03:41
@DmitriyLewen DmitriyLewen requested a review from afdesk August 28, 2024 03:41
@knqyf263 knqyf263 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into aquasecurity:main with commit 391448a Aug 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(secret): long secrets with short line prefix/suffix contain characters from other lines
3 participants