Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(secret): long secrets with short line prefix/suffix contain characters from other lines #7411

Closed
DmitriyLewen opened this issue Aug 28, 2024 · 0 comments · Fixed by #7412
Closed

bug(secret): long secrets with short line prefix/suffix contain characters from other lines #7411

DmitriyLewen opened this issue Aug 28, 2024 · 0 comments · Fixed by #7412
Assignees
@DmitriyLewen
Labels
kind/bug Categorizes issue or PR as related to a bug. scan/secret Issues relating to secret scanning

Comments

@DmitriyLewen
Copy link
Contributor

Description

long secrets with short line prefix/suffix (characters before and after secret) contain characters from other strings.
We limit long lines, but we need to include characters only from detected line.

See example:

   1   asd
   2   aaaa
   3 [ asd
aaaa
jwt: ***********************************************************************************************************************************************************

asda
   4
@DmitriyLewen DmitriyLewen added kind/bug Categorizes issue or PR as related to a bug. scan/secret Issues relating to secret scanning labels Aug 28, 2024
@DmitriyLewen DmitriyLewen self-assigned this Aug 28, 2024
@DmitriyLewen DmitriyLewen mentioned this issue Aug 28, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriyLewen DmitriyLewen

Labels
kind/bug Categorizes issue or PR as related to a bug. scan/secret Issues relating to secret scanning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(secret): use only line with secret for long secret lines DmitriyLewen/trivy
1 participant
@DmitriyLewen