Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add allowed values for CLI flags #4800

Merged
merged 7 commits into from
Jul 17, 2023
Merged

refactor: add allowed values for CLI flags #4800

merged 7 commits into from
Jul 17, 2023

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Jul 9, 2023

Description

CLI flags now define allowed values. The passed value is validated and it shows an error with unsupported values.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Jul 9, 2023
@knqyf263 knqyf263 requested a review from DmitriyLewen July 16, 2023 12:31
@knqyf263 knqyf263 marked this pull request as ready for review July 16, 2023 13:36
DmitriyLewen
DmitriyLewen reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Left 1 comment.

pkg/flag/options.go Show resolved Hide resolved
@knqyf263 knqyf263 added this pull request to the merge queue Jul 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2023
@knqyf263 knqyf263 added this pull request to the merge queue Jul 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2023
@knqyf263 knqyf263 added this pull request to the merge queue Jul 17, 2023
Merged via the queue into aquasecurity:main with commit aca11b9 Jul 17, 2023
@knqyf263 knqyf263 deleted the allowed_values branch July 17, 2023 13:54
AnaisUrlichs pushed a commit to AnaisUrlichs/trivy that referenced this pull request Aug 10, 2023
@knqyf263 @AnaisUrlichs
refactor: add allowed values for CLI flags (aquasecurity#4800)
912a4c7 
* refactor: rename Value to Default

* refactor: support allowed values for CLI flags

* docs: auto-generate

* test: fix

* test: add tests for flags
@DmitriyLewen DmitriyLewen mentioned this pull request Nov 13, 2023
Merged
7 tasks
@knqyf263 knqyf263 mentioned this pull request Jan 6, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

@AnaisUrlichs AnaisUrlichs AnaisUrlichs approved these changes

@itaysk itaysk Awaiting requested review from itaysk

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knqyf263 @AnaisUrlichs @DmitriyLewen