fix(cli): inconsistent behavior across CLI flags, environment variables, and config files #5843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a recent update to Trivy, we introduced validation and alias functionalities for CLI flags. However, we realized that these enhancements had not been uniformly applied to other configuration methods, specifically environment variables and the configuration file (trivy.yaml). This PR addresses this oversight by extending the validation and alias features across all configuration settings, ensuring consistency and improved usability.
To facilitate this integration, we've added a
Parse()
method. This method is designed to be called before accessing values through theValue()
method, mirroring the interface pattern found in the Go's standardflag
package (flag package documentation). This addition ensures that value retrieval does not result in errors and that the parsing process is streamlined across different settings.Additionally, we've refactored the handling of default flag values. Previously, the logic was branched based on the type of the
Default
field of each flag. We've now shifted this approach to leverage Go's generics, allowing for a more explicit and type-safe representation of default values.Related issues
--scanners
aliases across CLI flags, environment variables, and config files #5803Checklist