golang/go not updated

[frezbo]

Go 1.19 was released on 2nd Aug, 2022, but it seems I didn't get a renovate PR for the same.

The renovate config clearly sees the deps here:

seems something got broken recently. Creating it here to track why some deps doesn't gets updated. Had a similar issue with goimports as referenced in #185

[frezbo]

Seems renovate has failed to update go in aqua-registry too: https://github.com/aquaproj/aqua-registry/tree/main/pkgs/golang/go

[suzuki-shunsuke]

• go.mod 1.19 update failed with cryptic error message before the go docker image was updated renovatebot/renovate#16933
• Disable go version updates by default renovatebot/renovate#16715

---

Hmm... Sorry these are unrelated.
These are about go.mod's go directive.

[suzuki-shunsuke]

Thank you for your report.

[frezbo]

I'll try to see what's broken when I get some time, seems renovate is a bit flaky this week

[suzuki-shunsuke]

Thank you. Recently I'm a little busy so it is difficult to investigate the issue about Renovate for now.

[suzuki-shunsuke]

Related tweet (Japanese).
https://twitter.com/ponkio_o/status/1555048136825262081

[suzuki-shunsuke]

Maybe this warning is about go datasource?
#177

aqua-renovate-config/default.json

Lines 95 to 102 in c151d10

	{
	"fileMatch": ["\\.?aqua\\.ya?ml"],
	"matchStrings": [
	" +['\"]?(version|ref)['\"]? *: +['\"]?(?<currentValue>[^'\" \\n]+?)['\"]? +# renovate: depName=(?<depName>[^\\n]+)",
	" +['\"]?name['\"]? *: +['\"]?(?<depName>[^\\n]+)*@(?<currentValue>[^'\" \\n]+)['\"]?"
	],
	"datasourceTemplate": "go"
	}

[suzuki-shunsuke]

I guess we can ignore this warning although we would like to remove the warning.
aqua-renovate-config's default preset uses two datasources, github_release datasource and go datasource.

Renovate tries to get each package's version from these datasources, but Renovate can get the version from only one datasource.

For example, Renovate would succeed to get the version of suzuki-shunsuke/tfcmt from github_release datasource
but would fail to get it from go datasource.
This failure would be shown as the warning, but I guess we can ignore this warning.

Note that the above description is just my assumption.

[suzuki-shunsuke]

Hmm...
Maybe we can distinguish the datasource by the regular expression of package name.

go datasource package name includes a period ..

pkgs/golang.org/x/tools/cmd/goimports/registry.yaml
2:  - type: go_install
3-    name: golang.org/x/tools/cmd/goimports
4-    path: golang.org/x/tools/cmd/goimports
5-    repo_owner: golang
6-    repo_name: tools
7-    version_source: github_tag

pkgs/golang.org/x/tools/gopls/registry.yaml
2:  - type: go_install
3-    name: golang.org/x/tools/gopls
4-    aliases:
5-      - name: golang/tools/gopls
6-    path: golang.org/x/tools/gopls
7-    repo_owner: golang

pkgs/golang.org/x/perf/cmd/benchstat/registry.yaml
2:  - type: go_install
3-    path: golang.org/x/perf/cmd/benchstat
4-    description: Benchstat computes and compares statistics about benchmarks
5-    link: https://pkg.go.dev/golang.org/x/perf/cmd/benchstat
6-

[suzuki-shunsuke]

#192

[suzuki-shunsuke]

Released. https://github.com/aquaproj/aqua-renovate-config/releases/tag/1.2.1

[suzuki-shunsuke]

golang/go was updated from 1.18.4 to 1.18.5, but not updated to 1.19.
suzuki-shunsuke/test-renovate#158

I guess this is because 1.19 is invalid as semver.
When go1.19.x will be released, Renovate would update golang/go.

aqua-renovate-config/default.json

Lines 45 to 54 in a8a9c0a

	{
	"fileMatch": ["\\.?aqua\\.ya?ml"],
	"matchStrings": [
	" +['\"]?version['\"]? *: +['\"]?(go)?(?<currentValue>[^'\" \\n]+)['\"]? +# renovate: depName=golang/go[ \\n]",
	" +['\"]?name['\"]? *: +['\"]?golang/go@(go)?(?<currentValue>[^'\" \\n]+)['\"]?"
	],
	"extractVersionTemplate": "^go(?<version>.*)$",
	"datasourceTemplate": "github-tags",
	"depNameTemplate": "golang/go"
	},

• https://docs.renovatebot.com/modules/versioning/
• https://semver.org/

I checked the Renovate log. The version was semver.

{
            "depName": "golang/go",
            "currentValue": "go1.18.4",
            "datasource": "github-releases",
            "replaceString": " name: golang/[email protected]",
            "depIndex": 0,
            "updates": [],
            "warnings": [],
            "versioning": "semver",
            "skipReason": "invalid-value"
          }

[suzuki-shunsuke]

Renovate supports various versioning, but I don't know which is best for golang/go.
https://docs.renovatebot.com/modules/versioning/

[frezbo]

golang/go was updated from 1.18.4 to 1.18.5, but not updated to 1.19.

yeh, i guess that's right, i manually updated for now.

[frezbo]

I'm closing this issue for now, since this is a minor inconvenience.

[frezbo]

Thanks for chasing the issue and putting up a fix 👍

[rust84]

I tried semver-coerced with no luck and ended up just setting it to loose.

  "packageRules": [
    {
      "matchDatasources": ["github-tags"],
      "matchPackageNames": ["golang/go"],
      "versioning": "loose"
    }
  ]