Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod 1.19 update failed with cryptic error message before the go docker image was updated #16933

Closed
SuperSandro2000 opened this issue Aug 3, 2022 · 6 comments · Fixed by #16961
Assignees
Labels
status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality

Comments

@SuperSandro2000
Copy link
Contributor

SuperSandro2000 commented Aug 3, 2022

How are you running Renovate?

Mend Renovate hosted app on github.com

Was this something which used to work for you, and then stopped?

It used to work, and then stopped

Describe the bug

The go.mod update from 1.18 to 1.19 failed in sapcc/keppel#107 because renovate bot was still using a go 1.18 docker image docker.io/renovate/go:1.18.5.
The exact detail can be found in the log go: go.mod file indicates go 1.19, but maximum version supported by tidy is 1.18 but on the PR only a very generic Process exited with exit code "1" error was logged.

Relevant debug logs

Logs
DEBUG: Docker image is already prefetched: docker.io/renovate/go:1.18.5@sha256:e451d2af602fcf158786cb2f1bb1444aefd89768f3c7708a04a768788f6a0a60(branch="renovate/go-1.x")
DEBUG: Executing command(branch="renovate/go-1.x")
{
  "command": "docker run --rm --name=renovate_go --label=renovate_child -v \"/mnt/renovate/gh/sapcc/keppel\":\"/mnt/renovate/gh/sapcc/keppel\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -e GOPATH -e GOPROXY -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e GIT_CONFIG_KEY_3 -e GIT_CONFIG_VALUE_3 -e GIT_CONFIG_KEY_4 -e GIT_CONFIG_VALUE_4 -e GIT_CONFIG_KEY_5 -e GIT_CONFIG_VALUE_5 -e BUILDPACK_CACHE_DIR -w \"/mnt/renovate/gh/sapcc/keppel\" docker.io/renovate/go:1.18.5 bash -l -c \"go get -d -t ./... && go mod tidy && go mod vendor && go mod tidy && go mod tidy\""
}
DEBUG: rawExec err(branch="renovate/go-1.x")
{
  "err": {
    "name": "ExecError",
    "cmd": "/bin/sh -c docker run --rm --name=renovate_go --label=renovate_child -v \"/mnt/renovate/gh/sapcc/keppel\":\"/mnt/renovate/gh/sapcc/keppel\" -v \"/tmp/renovate-cache\":\"/tmp/renovate-cache\" -e GOPATH -e GOPROXY -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e GIT_CONFIG_KEY_3 -e GIT_CONFIG_VALUE_3 -e GIT_CONFIG_KEY_4 -e GIT_CONFIG_VALUE_4 -e GIT_CONFIG_KEY_5 -e GIT_CONFIG_VALUE_5 -e BUILDPACK_CACHE_DIR -w \"/mnt/renovate/gh/sapcc/keppel\" docker.io/renovate/go:1.18.5 bash -l -c \"go get -d -t ./... && go mod tidy && go mod vendor && go mod tidy && go mod tidy\"",
    "stderr": "go: downloading github.com/sapcc/go-api-declarations v1.2.0\ngo: downloading github.com/sapcc/go-bits v0.0.0-20220801132244-1778c461b6c3\ngo: downloading github.com/spf13/cobra v1.5.0\ngo: downloading github.com/prometheus/client_golang v1.12.2\ngo: downloading github.com/dlmiddlecote/sqlstats v1.0.2\ngo: downloading github.com/go-redis/redis/v8 v8.11.5\ngo: downloading github.com/gorilla/mux v1.8.0\ngo: downloading github.com/rs/cors v1.8.2\ngo: downloading github.com/docker/distribution v2.8.1+incompatible\ngo: downloading github.com/opencontainers/go-digest v1.0.0\ngo: downloading github.com/gofrs/uuid v4.2.0+incompatible\ngo: downloading gopkg.in/gorp.v2 v2.2.0\ngo: downloading github.com/alicebob/miniredis/v2 v2.22.0\ngo: downloading github.com/go-redis/redis_rate/v9 v9.1.2\ngo: downloading github.com/golang-jwt/jwt/v4 v4.4.2\ngo: downloading golang.org/x/crypto v0.0.0-20220722155217-630584e8d5aa\ngo: downloading github.com/databus23/goslo.policy v0.0.0-20210929125152-81bf2876dbdb\ngo: downloading github.com/gophercloud/gophercloud v0.25.0\ngo: downloading github.com/gophercloud/utils v0.0.0-20220704184730-55bdbbaec4ba\ngo: downloading github.com/majewsky/schwift v1.1.0\ngo: downloading github.com/opencontainers/image-spec v1.0.2\ngo: downloading github.com/inconshreveable/mousetrap v1.0.0\ngo: downloading github.com/spf13/pflag v1.0.5\ngo: downloading github.com/beorn7/perks v1.0.1\ngo: downloading github.com/cespare/xxhash/v2 v2.1.2\ngo: downloading github.com/golang/protobuf v1.5.2\ngo: downloading github.com/prometheus/client_model v0.2.0\ngo: downloading github.com/prometheus/common v0.32.1\ngo: downloading github.com/prometheus/procfs v0.7.3\ngo: downloading golang.org/x/sys v0.0.0-20220412211240-33da011f77ad\ngo: downloading google.golang.org/protobuf v1.28.0\ngo: downloading github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f\ngo: downloading github.com/sergi/go-diff v1.2.0\ngo: downloading github.com/lib/pq v1.10.6\ngo: downloading github.com/rabbitmq/amqp091-go v1.3.4\ngo: downloading github.com/alicebob/gopher-json v0.0.0-20200520072559-a9ecdc9d1d3a\ngo: downloading github.com/yuin/gopher-lua v0.0.0-20210529063254-f4c35e4016d9\ngo: downloading gopkg.in/yaml.v2 v2.4.0\ngo: downloading github.com/jpillora/longestcommon v0.0.0-20161227235612-adb9d91ee629\ngo: downloading github.com/hashicorp/golang-lru v0.5.4\ngo: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1\ngo: downloading github.com/hashicorp/go-multierror v1.1.1\ngo: downloading go.uber.org/atomic v1.9.0\ngo: downloading golang.org/x/text v0.3.7\ngo: downloading github.com/mitchellh/go-homedir v1.1.0\ngo: downloading github.com/hashicorp/errwrap v1.0.0\ngo: go.mod file indicates go 1.19, but maximum version supported by tidy is 1.18\n",
    "stdout": "",
    "options": {
      "cwd": "/mnt/renovate/gh/sapcc/keppel",
      "encoding": "utf-8",
      "env": {
        "GOPATH": "/tmp/renovate-cache/others/go",
        "GOPROXY": "https://proxy.golang.org,direct",
        "GOFLAGS": "-modcacherw",
        "CGO_ENABLED": "0",
        "GIT_CONFIG_KEY_0": "url.https://**redacted**@github.com/.insteadOf",
        "GIT_CONFIG_VALUE_0": "ssh://**redacted**@github.com/",
        "GIT_CONFIG_KEY_1": "url.https://**redacted**@github.com/.insteadOf",
        "GIT_CONFIG_VALUE_1": "[email protected]:",
        "GIT_CONFIG_KEY_2": "url.https://**redacted**@github.com/.insteadOf",
        "GIT_CONFIG_VALUE_2": "https://github.com/",
        "GIT_CONFIG_COUNT": "6",
        "GIT_CONFIG_KEY_3": "url.https://**redacted**@api.github.com/.insteadOf",
        "GIT_CONFIG_VALUE_3": "ssh://**redacted**@api.github.com/",
        "GIT_CONFIG_KEY_4": "url.https://**redacted**@api.github.com/.insteadOf",
        "GIT_CONFIG_VALUE_4": "[email protected]:",
        "GIT_CONFIG_KEY_5": "url.https://**redacted**@api.github.com/.insteadOf",
        "GIT_CONFIG_VALUE_5": "https://api.github.com/",
        "HOME": "/home/ubuntu",
        "PATH": "/home/ubuntu/.npm-global/bin:/usr/local/node/14.18.1/bin:/home/ubuntu/.local/bin:/usr/local/python/3.9.3/bin:/home/ubuntu/bin:/home/ubuntu/renovateapp/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
        "LC_ALL": "C.UTF-8",
        "LANG": "C.UTF-8",
        "BUILDPACK_CACHE_DIR": "/tmp/renovate-cache/buildpack"
      },
      "maxBuffer": 10485760,
      "timeout": 900000
    },
    "exitCode": 1,
    "message": "Process exited with exit code \"1\"",
    "stack": "ExecError: Process exited with exit code \"1\"\n    at ChildProcess.<anonymous> (/home/ubuntu/renovateapp/node_modules/renovate/dist/util/exec/common.js:85:24)\n    at ChildProcess.emit (events.js:412:35)\n    at ChildProcess.emit (domain.js:475:12)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:282:12)"
  }
}

Have you created a minimal reproduction repository?

No reproduction, but I have linked to a public repo where it occurs

@SuperSandro2000 SuperSandro2000 added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Aug 3, 2022
@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Aug 3, 2022

@SuperSandro2000 Something went wrong when you copy/pasted your logs, the Have you created a minimal reproduction repository? section is included in the logs toggle.

Please edit your post so it displays the missing section again. 😉


Edit: this issue seems related:

@SuperSandro2000
Copy link
Contributor Author

SuperSandro2000 commented Aug 3, 2022

Forgot a line break at the end of the logs.

We are fine with the go version being updated but the error message was not helpful and the process should be improved for future new go versions.

@nabeelsaabna
Copy link
Contributor

nabeelsaabna commented Aug 4, 2022

since your .github/renovate.json includes:

  "constraints": {
    "go": "1.18"
  },

is the issue only related to the message inside Artifact update problem comment ?

@rarkins
Copy link
Collaborator

rarkins commented Aug 4, 2022

If the user has added constraints for go then this is by design and not a bug

@SuperSandro2000
Copy link
Contributor Author

is the issue only related to the message inside Artifact update problem comment ?

Yes but good reminder. I wonder why the update was attempted in the first place.

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 32.144.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants