add api query getFungibleAssetActivities #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmigo
requested review from
0xmaayan,
gregnazario,
heliuchuan and
a team
as code owners
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
0xmigo
force-pushed
the
jin/getFungibleAssetActivities
branch
from
a89c042 to
bea632b
Compare
heliuchuan
reviewed
Oct 17, 2023
0xmaayan
reviewed
Oct 17, 2023
| @@ -19,4 +19,23 @@ describe("FungibleAsset", () => { | |||
| expect(data[0]).toHaveProperty("asset_type"); | |||
| expect(data[0].asset_type).toEqual(APT_COIN_TYPE); | |||
| }); | |||
|
|
|||
| test("it should fetch fungible asset activities with correct number and asset type ", async () => { | |||
| const config = new AptosConfig({ network: Network.LOCAL }); | |||
There was a problem hiding this comment.
let's declare all those repated variables (config, aptos, APT_COIN_TYPE, etc) at the top of the file
There was a problem hiding this comment.
Good call. I will address this part in the next PR on the stack, so there won't be conflict.
0xmaayan
reviewed
Oct 17, 2023
0xmaayan
reviewed
Oct 17, 2023
0xmaayan
reviewed
Oct 17, 2023
0xmaayan
reviewed
Oct 17, 2023
0xmigo
force-pushed
the
jin/getFungibleAssetMetadata
branch
from
2402520 to
6ab7b88
Compare
0xmigo
force-pushed
the
jin/getFungibleAssetActivities
branch
2 times, most recently
from
5efb885 to
dcb4c06
Compare
|
Update - Fixed most part from comments. Will address the repeated use of same const variable in the next(last) PR in the stack |
0xmigo
force-pushed
the
jin/getFungibleAssetMetadata
branch
from
6ab7b88 to
7078921
Compare
0xmigo
force-pushed
the
jin/getFungibleAssetActivities
branch
from
dcb4c06 to
0aa86bf
Compare
heliuchuan
approved these changes
Oct 17, 2023
0xmigo
force-pushed
the
jin/getFungibleAssetActivities
branch
from
0aa86bf to
8dee394
Compare
0xmigo
force-pushed
the
jin/getFungibleAssetActivities
branch
from
8dee394 to
deff2e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add getFungibleAssetActivities api query
Test Plan
pnpm test
pnpm fmt
Related Links