Add new api getFungibleAssetMetadata #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
0xmigo
requested review from
0xmaayan,
gregnazario and
heliuchuan
as code owners
0xmigo
force-pushed
the
jin/getFungibleAssetMetadata
branch
from
ff1b95f to
2402520
Compare
This was referenced Oct 17, 2023
gregnazario
reviewed
Oct 17, 2023
| @@ -106,6 +111,7 @@ applyMixin(Aptos, Coin, "coin"); | |||
| applyMixin(Aptos, Collection, "collection"); | |||
| applyMixin(Aptos, Event, "event"); | |||
| applyMixin(Aptos, Faucet, "faucet"); | |||
| applyMixin(Aptos, FungibleAsset, "fungible_asset"); | |||
There was a problem hiding this comment.
Let's avoid snake case and have everything use camelcase. I'm going to change the rest but it ends up with a lot of conflicts
There was a problem hiding this comment.
hmm wait, thats the class name, I think it make sense for snake case? Similar to TransactionSubmission on line 109
0xmigo
force-pushed
the
jin/getFungibleAssetMetadata
branch
from
2402520 to
6ab7b88
Compare
0xmigo
force-pushed
the
jin/getFungibleAssetMetadata
branch
from
6ab7b88 to
7078921
Compare
heliuchuan
reviewed
Oct 17, 2023
| test("it should fetch fungible asset metadata", async () => { | ||
| const config = new AptosConfig({ network: Network.LOCAL }); | ||
| const aptos = new Aptos(config); | ||
| const APT_COIN_TYPE = "0x1::aptos_coin::AptosCoin"; |
There was a problem hiding this comment.
i assume you'll handle this somewhere in pr stack
heliuchuan
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the new query getFungibleAssetMetadata.
Note: This time I am modifying on how we construct the function in
/internalPlease take a lookTest Plan
pnpm fmt
pnpm lint
pnpm test
Related Links