-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create_token method in token.move #8825
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e1e7d59
Add create_token method in token.move
vusirikala 231d10c
Merge branch 'satya/create-guid' into satya/token-uuid
vusirikala 610cda6
Merge branch 'satya/create-guid' into satya/token-uuid
vusirikala 74fd59c
add deprecated flag to create_token_from_account
vusirikala 2608a7d
Merge branch 'satya/create-guid' into satya/token-uuid
vusirikala f753fc9
Merge branch 'satya/create-guid' into satya/token-uuid
vusirikala d2b89cd
Add test case and rename to create
vusirikala a89a3d1
Add feature flag condition in test case
vusirikala 92cd3fe
enabled feature flag in the unit test
vusirikala 075e642
Enabling auid feature flag in ambassador unit tests
vusirikala b45d7ea
Merge branch 'satya/create-guid' into satya/token-uuid
vusirikala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,6 +106,22 @@ module aptos_token_objects::token { | |
}; | ||
} | ||
|
||
/// Creates a new token object with a unique address and returns the ConstructorRef | ||
/// for additional specialization. | ||
public fun create_token( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: How about just name this "create" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
creator: &signer, | ||
collection_name: String, | ||
description: String, | ||
name: String, | ||
royalty: Option<Royalty>, | ||
uri: String, | ||
): ConstructorRef { | ||
let creator_address = signer::address_of(creator); | ||
let constructor_ref = object::create_object(creator_address); | ||
create_common(&constructor_ref, creator_address, collection_name, description, name, royalty, uri); | ||
constructor_ref | ||
} | ||
|
||
/// Creates a new token object from a token name and returns the ConstructorRef for | ||
/// additional specialization. | ||
public fun create_named_token( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark create_from_account as deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.