Add create_token method in token.move #8825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vusirikala
requested review from
saharct,
davidiw,
movekevin and
wrwg
as code owners
igor-aptos
reviewed
Jun 24, 2023
| @@ -106,6 +106,22 @@ module aptos_token_objects::token { | |||
| }; | |||
| } | |||
|
|
|||
| /// Creates a new token object with a unique address and returns the ConstructorRef | |||
| /// for additional specialization. | |||
| public fun create_token( | |||
There was a problem hiding this comment.
Mark create_from_account as deprecated
movekevin
approved these changes
Jun 25, 2023
movekevin
reviewed
Jun 25, 2023
movekevin
reviewed
Jun 25, 2023
I've check that right now we are using |
movekevin
reviewed
Jun 26, 2023
| @@ -199,7 +199,7 @@ module aptos_token_objects::aptos_token { | |||
| property_types: vector<String>, | |||
| property_values: vector<vector<u8>>, | |||
| ): ConstructorRef acquires AptosCollection { | |||
| let constructor_ref = token::create_from_account( | |||
| let constructor_ref = token::create_token( | |||
There was a problem hiding this comment.
This needs to be behind the same feature flag as create_guid otherwise this would always fail before the flag is enabled
There was a problem hiding this comment.
If auids are enabled, I am now calling create method. If auids are disabled, I am calling create_from_account method. Is that okay?
movekevin
reviewed
Jun 26, 2023
| @@ -106,6 +106,22 @@ module aptos_token_objects::token { | |||
| }; | |||
| } | |||
|
|
|||
| /// Creates a new token object with a unique address and returns the ConstructorRef | |||
| /// for additional specialization. | |||
| public fun create_token( | |||
There was a problem hiding this comment.
nit: How about just name this "create"
I added a unit test now. But it runs only if the AUIDs are enabled. |
movekevin
approved these changes
Jun 26, 2023
| option::none(), | ||
| uri, | ||
| ); | ||
| let constructor_ref = if (std::features::auids_enabled()) { |
There was a problem hiding this comment.
nit: Can you add an import for std::features and just call features::auids_enabled here to keep it consistent?
That's fine. It should pass after merging this into the create-guid branch |
vusirikala
added a commit
that referenced
this pull request
Jun 26, 2023
* Add native function create_guid * Append a constant to hash_arg * Add move test to verify uniqueness of guids * Charging gas for create_guid method * Add gas for create guid * Add create_guid to object.move * Change GUID to UUID * Change GUID to UUID in tests * Change GUID to UUID in tests * Add create_object method in object.move * Fix typo * Fix typo * fix trigger condition for build jobs * Add native_get_txn_hash * Add native_get_txn_hash * Deprecate the old create_object_from_object and create_object_from_account * Bumped the latest_gas_version to 10 * Bumped gas version to 10 * Changed gas feature version to 9 * Moved transaction hash hashing to authenticator.rs * Add documentation to create_uuid method * Use AuthenticationKey struct for create_uuid * Remove deprecated comment * Updatd comments in object.move * Changed create_uuid to use only one hash * Add create_unique_address function * Add drop, store capabilities to UUID * Resetting the create_object_from_account function * Add comment for create_object function * feature gating * deprecated tag * Add transaction context spec * Add a test case in transaction_context * Updated move test case * Add create_token method * Update test cases * rust lint * Changed comments * Remove create_token method * Add feature flag for test * fix a unit test * Fix unit test * moved unit test to object.move * changing uuid to auid * rust lint * Minor changes * Change uuid to auid in tests * Change uuid to auid in tests * changed name to generate_unique_address * Fixed the specs which timeout * Fixed a unit test * Shift test from e2e-move-tests to transaction_context.move * Add a comment in object.move * rust lint * Add create_token method in token.move (#8825) * Add create_token method in token.move * add deprecated flag to create_token_from_account * Add test case and rename to create * Add feature flag condition in test case * enabled feature flag in the unit test * Enabling auid feature flag in ambassador unit tests * Enable auid flag in an ambassador.move unit test * Changed gas cost * changed name from generate_unique_address to generate_auid_address * Updated a comment * Feature gate get_txn_hash * changing names in test cases --------- Co-authored-by: geekflyer <[email protected]> Co-authored-by: Junkil Park <[email protected]>
gedigi
pushed a commit
that referenced
this pull request
Aug 2, 2023
* Add native function create_guid * Append a constant to hash_arg * Add move test to verify uniqueness of guids * Charging gas for create_guid method * Add gas for create guid * Add create_guid to object.move * Change GUID to UUID * Change GUID to UUID in tests * Change GUID to UUID in tests * Add create_object method in object.move * Fix typo * Fix typo * fix trigger condition for build jobs * Add native_get_txn_hash * Add native_get_txn_hash * Deprecate the old create_object_from_object and create_object_from_account * Bumped the latest_gas_version to 10 * Bumped gas version to 10 * Changed gas feature version to 9 * Moved transaction hash hashing to authenticator.rs * Add documentation to create_uuid method * Use AuthenticationKey struct for create_uuid * Remove deprecated comment * Updatd comments in object.move * Changed create_uuid to use only one hash * Add create_unique_address function * Add drop, store capabilities to UUID * Resetting the create_object_from_account function * Add comment for create_object function * feature gating * deprecated tag * Add transaction context spec * Add a test case in transaction_context * Updated move test case * Add create_token method * Update test cases * rust lint * Changed comments * Remove create_token method * Add feature flag for test * fix a unit test * Fix unit test * moved unit test to object.move * changing uuid to auid * rust lint * Minor changes * Change uuid to auid in tests * Change uuid to auid in tests * changed name to generate_unique_address * Fixed the specs which timeout * Fixed a unit test * Shift test from e2e-move-tests to transaction_context.move * Add a comment in object.move * rust lint * Add create_token method in token.move (#8825) * Add create_token method in token.move * add deprecated flag to create_token_from_account * Add test case and rename to create * Add feature flag condition in test case * enabled feature flag in the unit test * Enabling auid feature flag in ambassador unit tests * Enable auid flag in an ambassador.move unit test * Changed gas cost * changed name from generate_unique_address to generate_auid_address * Updated a comment * Feature gate get_txn_hash * changing names in test cases --------- Co-authored-by: geekflyer <[email protected]> Co-authored-by: Junkil Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
create_tokenmethod in token.move file.