Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-sdk-builder: default to using local types #5987

Merged
merged 1 commit into from
Dec 24, 2022

Conversation

bonedaddy
Copy link
Contributor

Addresses part of the issues mentioned in #5986 (comment) by defaulting to local_types generation.

aptos_sdk_builder::rust::output(&mut out, &abis, /* local types */ false)
aptos_sdk_builder::rust::output(&mut out, &abis, /* local types */ true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how CI handles this, because this could have other consequences

@gregnazario gregnazario self-assigned this Dec 22, 2022
@gregnazario gregnazario enabled auto-merge (rebase) December 23, 2022 06:00
@davidiw davidiw force-pushed the fix/rust-sdk-builder branch from e82d1f3 to 4d77edc Compare December 24, 2022 00:20
@davidiw davidiw disabled auto-merge December 24, 2022 00:20
@davidiw davidiw enabled auto-merge (squash) December 24, 2022 00:21
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 4d77edc28f01ae0049d18be38856a5faae37beee

performance benchmark with full nodes : 6678 TPS, 5944 ms latency, 8100 ms p99 latency,no expired txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4d77edc28f01ae0049d18be38856a5faae37beee

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4d77edc28f01ae0049d18be38856a5faae37beee (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7688 TPS, 5029 ms latency, 6600 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 4d77edc28f01ae0049d18be38856a5faae37beee
compatibility::simple-validator-upgrade::single-validator-upgrade : 5131 TPS, 7994 ms latency, 10100 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 4d77edc28f01ae0049d18be38856a5faae37beee
compatibility::simple-validator-upgrade::half-validator-upgrade : 4702 TPS, 8992 ms latency, 11600 ms p99 latency,no expired txns
4. upgrading second batch to new version: 4d77edc28f01ae0049d18be38856a5faae37beee
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6628 TPS, 5839 ms latency, 10800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4d77edc28f01ae0049d18be38856a5faae37beee passed
Test Ok

@davidiw davidiw merged commit 27a6431 into aptos-labs:main Dec 24, 2022
@Markuze Markuze mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants