Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Cleanup SDK generator for ABIs #5986

Closed
1 task
gregnazario opened this issue Dec 22, 2022 · 3 comments
Closed
1 task

[Feature Request] Cleanup SDK generator for ABIs #5986

gregnazario opened this issue Dec 22, 2022 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request Stale

Comments

@gregnazario
Copy link
Contributor

🚀 Feature Request

Some people want to generate ABIs for their code, and there's a mostly working generator existing already.

Motivation

Is your feature request related to a problem? Please describe.
The aptos-sdk-builder is a pretty good tool for Rust bindings, and is used throughout the aptos-core codebase. But, it has some downfalls & is missing some documentation on how to use it fully.

Pitch

Describe the solution you'd like
Get the aptos-sdk-builder in a place where people can use it to generate ABI bindings in Rust first, then possibly Go and other languages.

Additional context

Let's list any rough points here that need to be cleaned up

  • Documentation on how to run
  • [ ]
@gregnazario gregnazario added the enhancement New feature or request label Dec 22, 2022
@bonedaddy
Copy link
Contributor

For rust the issue seems to be related to two methods of code generation, one with "local types" the other without.

The comments for aptos_sdk_builder::rust::output seem to indicate that local_types when set to true is intended to be used within the aptos codebase itself, however I don't believe this is the case. When local_types is set to false, the way structs etc.. are generated are using the private initializers, only available within the crate the type is defined in.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Feb 6, 2023
@gregnazario gregnazario removed the Stale label Feb 16, 2023
@gregnazario gregnazario self-assigned this Feb 16, 2023
@lbmeiyi lbmeiyi moved this from 🆕 New to 📋 Backlog in Move Language and Runtime Feb 16, 2023
@clay-aptos clay-aptos added the documentation Improvements or additions to documentation label Mar 9, 2023
@clay-aptos clay-aptos moved this to 🆕 New in Aptos Docs Mar 9, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Apr 24, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Move Language and Runtime May 10, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Aptos Docs May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Stale
Projects
Archived in project
Archived in project
Development

No branches or pull requests

3 participants