[aptos-release-tooling] Add an option to compare release binary with on chain configs #5796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
movekevin
approved these changes
Dec 8, 2022
gregnazario
reviewed
Dec 8, 2022
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| use crate::utils::*; | |||
| use anyhow::Result; | |||
| use aptos_types::on_chain_config::FeatureFlag as AFeatureFlag; | |||
| use aptos_types::on_chain_config::{FeatureFlag as AFeatureFlag, Features as AFeatures}; | |||
There was a problem hiding this comment.
Let's in the future use names like AptosFeatureFlag instead of AFeatureFlag, the short adding (which I saw in the view functions as well), leads to easy mistakes and confusion later.
Comment on lines
102
to
103
| impl Features { | ||
| pub(crate) fn has_modified(&self, on_chain_features: &AFeatures) -> bool { |
There was a problem hiding this comment.
has_modified what's modified?
I look at the code, and it tells me that it's if one of hte feature flags provided is different than the current state. Could you add a comment for this?
Comment on lines
41
to
48
| fn fetch_and_compare<T: OnChainConfig + PartialEq>( | ||
| client: &Option<Client>, | ||
| expected: &T, | ||
| ) -> Result<bool> { |
There was a problem hiding this comment.
Similarly, fetch_and_compare, could you add a comment, or rename it to fetch_and_equals or something like that?
runtian-zhou
force-pushed
the
runtianz/compare_onchain_configs
branch
from
17a6d00 to
b081fa1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
0xchloe
approved these changes
Dec 13, 2022
areshand
pushed a commit
to areshand/aptos-core-1
that referenced
this pull request
Dec 18, 2022
…on chain configs (aptos-labs#5796) * [aptos-release-tooling] Add an option to compare release binary with on chain configs * fixup! [aptos-release-tooling] Add an option to compare release binary with on chain configs
runtian-zhou
added a commit
that referenced
this pull request
Dec 20, 2022
…on chain configs (#5796) * [aptos-release-tooling] Add an option to compare release binary with on chain configs * fixup! [aptos-release-tooling] Add an option to compare release binary with on chain configs
Closed
runtian-zhou
added a commit
that referenced
this pull request
Jan 3, 2023
…mainnet (#5936) * [release-tooling] Implement a parser from yaml (#5562) * [release-builder] Implement a parser for the framework release config * [release-builder] Add consensus config to release config * [release-tooling] Refactor the common logic for generating proposal. * [release tooling] multi-step proposal release tooling (#5834) Co-authored-by: chloeqjz <[email protected]> * [aptos-release-tooling] Add an option to compare release binary with on chain configs (#5796) * [aptos-release-tooling] Add an option to compare release binary with on chain configs * fixup! [aptos-release-tooling] Add an option to compare release binary with on chain configs Co-authored-by: 0xchloe <[email protected]> Co-authored-by: chloeqjz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option to compare on chain configs so that governance proposal will only be generated when they are modified.
Test Plan
Tested the fetch and compare logic with local aptos node. Was wondering if we should persist such test in smoke test?