[release-tooling] Implement a parser from yaml #5562

runtian-zhou · 2022-11-14T23:19:58Z

Description

Implement the parser to parse the release config from a yaml file. Added generation logic for consensus config as well.

Test Plan

cargo run -- write-default --output-path data/example.yaml

and cargo run -- generate-proposals --release-config data/example.yaml --output-dir <OUTPUT_DIR>

The upgrade smoke test will make sure upgrading consensus config would work as well.

This change is

runtian-zhou · 2022-11-14T23:20:45Z

aptos-move/aptos-release-builder/src/components/consensus_config.rs

+use aptos_types::on_chain_config::OnChainConsensusConfig;
+use move_model::{code_writer::CodeWriter, emit, emitln, model::Loc};
+
+pub fn generate_consensus_upgrade_proposal(


This logic is migrated from #5527. Maybe we could refactor that test later cc @igor-aptos

runtian-zhou · 2022-11-14T23:21:43Z

aptos-move/aptos-release-builder/data/example.yaml

@@ -0,0 +1,472 @@
+---


This is an example release config that contains all the information we could set using on chain config. Governance proposals could be generated automatically from this yaml file.

aptos-move/aptos-release-builder/src/components/consensus_config.rs

movekevin · 2022-11-15T23:57:48Z

aptos-move/aptos-release-builder/src/components/consensus_config.rs

+
+    emitln!(writer, "// Consensus config upgrade proposal\n");
+
+    if is_testnet {


nit: This is getting a bit redundant. Refactor this so each component doesn't have to do this themselves?

Yea I think I can refactor a bit here.

aptos-move/aptos-release-builder/src/components/feature_flags.rs

movekevin · 2022-11-15T23:59:12Z

aptos-move/aptos-release-builder/src/components/mod.rs

+
+    pub fn parse(serialized: &str) -> Result<Self> {
+        serde_yaml::from_str(serialized).map_err(|e| anyhow!("Failed to parse the config: {:?}", e))
+    }
 }

 impl Default for ReleaseConfig {
    fn default() -> Self {


Can you remind me where this is used again?

This is used in the upgrade test to make sure that the proposal generation process would always work. Though in the future we should be replacing this with the real release config we want to put for the next release cycle.

"in the future we should be replacing this with the real release config we want to put for the next release cycle." => What do you mean? Isn't this the default only?

Sry I mean that right now, we use ReleaseConfig::default in the testing pipeline. We should expect to see another test that uses sth like ReleaseConfig::upcoming_release to make sure the config is indeed valid. Hope that makes sense.

zekun000

oh this is really nice to have

runtian-zhou · 2022-11-16T05:33:21Z

Updated the PR with the refactor. Tho it doesn't look cleaner than before either... lemme know if you would like to keep it or not cc @movekevin

igor-aptos · 2022-11-16T19:02:34Z

This is probably beyond this PR, but what is the expected flow?

It seems to me release yaml is already materialized release decision - delta between two versions, i.e. what needs to be upgraded, for a specific network (i.e. testnet or not). Correct?
How are we going to generate all release yamls for a single release, for all the networks we have? (devnet, testnet, mainnet)

I.e. how would we know if any configs have changed, and whether governance proposal for updating onchain config (for example consensus one) is going to be needed?

Are we going to have a separate "snapshot" files telling us the state of various networks, and then create a snapshot for new release, and then create there release yamls as a delta between snapshots, for each of the networks?

runtian-zhou · 2022-11-16T20:13:33Z

Right now the PR only did the generation from yaml path. In the next PR I can add the logic to fetch the config from rest endpoint and compare it against the yaml file. cc @igor-aptos

igor-aptos

makes sense, just wanted to understand where this fits in.

igor-aptos · 2022-11-16T20:51:20Z

aptos-move/aptos-release-builder/src/components/mod.rs

-        base_path: &Path,
-        is_testnet: bool,
-    ) -> Result<()> {
+    pub fn generate_release_proposal_scripts(&self, base_path: &Path) -> Result<()> {
        let mut result = vec![];


you are not returning the result, or doing anything else with it?

This function will generate a set of move scripts into the base_path.

github-actions · 2022-11-16T21:41:08Z

✅ Forge suite `compat` success on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `1c5a2d849a894ad380bf4befec85f89a8901e141`

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 1c5a2d849a894ad380bf4befec85f89a8901e141 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7362 TPS, 5222 ms latency, 7200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 1c5a2d849a894ad380bf4befec85f89a8901e141
compatibility::simple-validator-upgrade::single-validator-upgrade : 4828 TPS, 8210 ms latency, 11200 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 1c5a2d849a894ad380bf4befec85f89a8901e141
compatibility::simple-validator-upgrade::half-validator-upgrade : 4476 TPS, 8927 ms latency, 11400 ms p99 latency,no expired txns
4. upgrading second batch to new version: 1c5a2d849a894ad380bf4befec85f89a8901e141
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6813 TPS, 5642 ms latency, 10400 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 1c5a2d849a894ad380bf4befec85f89a8901e141 passed
Test Ok

Grafana dashboard
Humio Logs
Test runner output
Test run is land-blocking

github-actions · 2022-11-16T21:41:49Z

✅ Forge suite `land_blocking` success on `1c5a2d849a894ad380bf4befec85f89a8901e141`

performance benchmark with full nodes : 6642 TPS, 5973 ms latency, 17300 ms p99 latency,(!) expired 880 out of 2837080 txns
Test Ok

Grafana dashboard
Humio Logs
Test runner output
Test run is land-blocking

* [release-builder] Implement a parser for the framework release config * [release-builder] Add consensus config to release config * [release-tooling] Refactor the common logic for generating proposal.

…mainnet (#5936) * [release-tooling] Implement a parser from yaml (#5562) * [release-builder] Implement a parser for the framework release config * [release-builder] Add consensus config to release config * [release-tooling] Refactor the common logic for generating proposal. * [release tooling] multi-step proposal release tooling (#5834) Co-authored-by: chloeqjz <[email protected]> * [aptos-release-tooling] Add an option to compare release binary with on chain configs (#5796) * [aptos-release-tooling] Add an option to compare release binary with on chain configs * fixup! [aptos-release-tooling] Add an option to compare release binary with on chain configs Co-authored-by: 0xchloe <[email protected]> Co-authored-by: chloeqjz <[email protected]>

runtian-zhou requested review from davidiw, areshand, gregnazario, wrwg, zekun000, movekevin and igor-aptos November 14, 2022 23:19

runtian-zhou commented Nov 14, 2022

View reviewed changes

[release-builder] Implement a parser for the framework release config

55e29f5

runtian-zhou force-pushed the runtianz/release_config branch from 89fd2a4 to 20e7d03 Compare November 15, 2022 20:00

movekevin reviewed Nov 15, 2022

View reviewed changes

zekun000 reviewed Nov 16, 2022

View reviewed changes

[release-builder] Add consensus config to release config

cc59a61

runtian-zhou force-pushed the runtianz/release_config branch from 20e7d03 to 83b05bb Compare November 16, 2022 05:34

[release-tooling] Refactor the common logic for generating proposal.

1c5a2d8

runtian-zhou force-pushed the runtianz/release_config branch from 83b05bb to 1c5a2d8 Compare November 16, 2022 07:28

movekevin approved these changes Nov 16, 2022

View reviewed changes

igor-aptos approved these changes Nov 16, 2022

View reviewed changes

runtian-zhou enabled auto-merge (squash) November 16, 2022 20:59

This comment has been minimized.

Sign in to view

runtian-zhou merged commit 620a809 into main Nov 16, 2022

runtian-zhou deleted the runtianz/release_config branch November 16, 2022 21:41

runtian-zhou mentioned this pull request Dec 20, 2022

[release-tooling] Cherry pick the release tooling into the framework-mainnet #5936

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-tooling] Implement a parser from yaml #5562

[release-tooling] Implement a parser from yaml #5562

runtian-zhou commented Nov 14, 2022 •

edited by geekflyer

Loading

runtian-zhou Nov 14, 2022

runtian-zhou Nov 14, 2022

movekevin Nov 15, 2022

runtian-zhou Nov 16, 2022

movekevin Nov 15, 2022

runtian-zhou Nov 16, 2022

movekevin Nov 16, 2022

runtian-zhou Nov 16, 2022

zekun000 left a comment

runtian-zhou commented Nov 16, 2022

igor-aptos commented Nov 16, 2022

runtian-zhou commented Nov 16, 2022

igor-aptos left a comment

igor-aptos Nov 16, 2022

runtian-zhou Nov 16, 2022

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 16, 2022

github-actions bot commented Nov 16, 2022


		emitln!(writer, "// Consensus config upgrade proposal\n");

		if is_testnet {

[release-tooling] Implement a parser from yaml #5562

[release-tooling] Implement a parser from yaml #5562

Conversation

runtian-zhou commented Nov 14, 2022 • edited by geekflyer Loading

Description

Test Plan

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zekun000 left a comment

Choose a reason for hiding this comment

runtian-zhou commented Nov 16, 2022

igor-aptos commented Nov 16, 2022

runtian-zhou commented Nov 16, 2022

igor-aptos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 16, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 1c5a2d849a894ad380bf4befec85f89a8901e141

github-actions bot commented Nov 16, 2022

✅ Forge suite land_blocking success on 1c5a2d849a894ad380bf4befec85f89a8901e141

runtian-zhou commented Nov 14, 2022 •

edited by geekflyer

Loading

✅ Forge suite `compat` success on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `1c5a2d849a894ad380bf4befec85f89a8901e141`

✅ Forge suite `land_blocking` success on `1c5a2d849a894ad380bf4befec85f89a8901e141`