[Spec] Completed the spec of from_bcs, any, copyable_any and type_info
#5712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkil-park
requested review from
areshand,
davidiw,
movekevin and
wrwg
as code owners
meng-xu-cs
suggested changes
Nov 29, 2022
movekevin
approved these changes
Nov 29, 2022
junkil-park
force-pushed
the
jpark/spec_from_bcs
branch
from
01382b2 to
b42e11c
Compare
meng-xu-cs
reviewed
Dec 1, 2022
| @@ -138,13 +138,15 @@ Checkout our developer doc on our token standard https://aptos.dev/concepts/coin | |||
| <code>amount: u64</code> | |||
| </dt> | |||
| <dd> | |||
|
|
|||
| the amount of tokens. Only property_version = 0 can have a value bigger than 1. | |||
There was a problem hiding this comment.
Why we have an update on this auto-generated file?
There was a problem hiding this comment.
Good call! This change has been removed from this commit when I rebased it onto the head.
…ype_info` Added the spec of the following modules: - `from_bcs` - `any` - `copyable_any` - `type_info` There are TODOs which should be filed as separate Github issues.
junkil-park
force-pushed
the
jpark/spec_from_bcs
branch
from
b42e11c to
9efc26d
Compare
meng-xu-cs
approved these changes
Dec 1, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Closed
areshand
pushed a commit
to areshand/aptos-core-1
that referenced
this pull request
Dec 18, 2022
…ype_info` (aptos-labs#5712) Added the spec of the following modules: - `from_bcs` - `any` - `copyable_any` - `type_info` There are TODOs which should be filed as separate Github issues.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the spec of the following modules:
from_bcsanycopyable_anytype_infoThere are TODOs which are filed as separate Github issues:
fixed_point32move-language/move#699boogie_helpers.rspanics for generic axioms move-language/move#700type_infomove-language/move#701type_info::type_namemove-language/move#702Test Plan
aptos move prove