-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[token] added functions for mutating token data #5017
Conversation
099a757
to
2b9daba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, thanks for reordering the functions
2b9daba
to
18870a4
Compare
18870a4
to
11e45df
Compare
196fc53
to
70fae48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be refactor the validations into a common function so we don't need to do it multiple times in these mutate functions.
8553abc
to
1b1542d
Compare
1b1542d
to
aa70f51
Compare
fa5890f
to
61ef496
Compare
61ef496
to
cfbab5b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cfbab5b
to
15fd388
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
❌ Forge suite
|
✅ Forge suite
|
Description
^
p.s. didn't delete any existing functions/tests, just moved the order so that it'll be in the order of maximum, uri, royalty, description, and properties
Test Plan
unit tests
This change is