Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Token] proposed changes for mainet release #5437

Closed
areshand opened this issue Nov 3, 2022 · 1 comment
Closed

[Token] proposed changes for mainet release #5437

areshand opened this issue Nov 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@areshand
Copy link
Contributor

areshand commented Nov 3, 2022

Summary
This proposal contains the following changes:

  • Token Collection Metadata Mutation functions
  • Token TokenData metadata mutation functions
  • A bug fix for collection supply underflow
  • Make a public entry for transfer with opt-in
  • Ensure royalty numerator is smaller than denominator

Motivation
support collectionData and TokenData fields mutation based on the mutability config so that creators can update the fields based on their own application logic
fix a bug that could cause underflow when burning an unlimited collection
provide an entry function so that the transferWithOptIn can be directly used by SDK
add assertion on royalty numerator to be smaller or equal to denominator

Rationale
The change is to fulfill the token standard specification that the token/collection metadata can be mutated when the mutability config is set. No other alternatives.

without providing entry function, the alternative is each sdk or wallet implementing their own script calling public functions. It adds more friction to use our token standard without any advantages.

Specification
The changes has been reviewed and merged to main branch
Mutation related changes:
#5382
#5265
#5017

Bug fix:
#5096

Provide entry point:
#4930

Ensure royalty numerator is smaller than denominator
#5444

Reference Implementation
None
Risks and Drawbacks
reviewed and audited
Future Potential

@areshand areshand added the enhancement New feature or request label Nov 3, 2022
@areshand areshand closed this as completed Nov 8, 2022
@areshand
Copy link
Contributor Author

areshand commented Nov 8, 2022

will create a same one in AIP repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant