Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Token] make transfer function public entry #4930

Merged
merged 1 commit into from
Oct 14, 2022
Merged

[Token] make transfer function public entry #4930

merged 1 commit into from
Oct 14, 2022

Conversation

areshand
Copy link
Contributor

@areshand areshand commented Oct 10, 2022 •
edited by geekflyer
Loading

Description

Test Plan

This change is Reviewable

MartianSiddharth
MartianSiddharth reviewed Oct 10, 2022
View reviewed changes
aptos-move/framework/aptos-token/sources/token.move Outdated
amount: u64,
) acquires TokenStore {
let token_id = create_token_id_raw(creator, collection_name, token_name, token_property_version);
let opt_in_transfer = borrow_global<TokenStore>(to).direct_transfer;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be easier to call transfer(from, token_id, to, amount) here

@areshand areshand force-pushed the make_transfer_public branch from 0163bb6 to 1420fa7 Compare October 10, 2022 21:36
@areshand areshand force-pushed the make_transfer_public branch from 1420fa7 to 12fa252 Compare October 10, 2022 21:36
@areshand areshand enabled auto-merge (rebase) October 14, 2022 22:14
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite compat success on 843b204dce971d98449b82624f4f684c7a18b991 ==> 12fa25209b37e8e44bcaadf542ba2571536d8728

Compatibility test results for 843b204dce971d98449b82624f4f684c7a18b991 ==> 12fa25209b37e8e44bcaadf542ba2571536d8728 (PR)
1. Check liveness of validators at old version: 843b204dce971d98449b82624f4f684c7a18b991
compatibility::simple-validator-upgrade::liveness-check : 7338 TPS, 5191 ms latency, 8900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 12fa25209b37e8e44bcaadf542ba2571536d8728
compatibility::simple-validator-upgrade::single-validator-upgrade : 4572 TPS, 9425 ms latency, 13400 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 12fa25209b37e8e44bcaadf542ba2571536d8728
compatibility::simple-validator-upgrade::half-validator-upgrade : 4643 TPS, 8965 ms latency, 11900 ms p99 latency,no expired txns
4. upgrading second batch to new version: 12fa25209b37e8e44bcaadf542ba2571536d8728
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7577 TPS, 5152 ms latency, 9000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 843b204dce971d98449b82624f4f684c7a18b991 ==> 12fa25209b37e8e44bcaadf542ba2571536d8728 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 12fa25209b37e8e44bcaadf542ba2571536d8728

performance benchmark with full nodes : 6780 TPS, 5883 ms latency, 9900 ms p99 latency,(!) expired 400 out of 2895780 txns
Test Ok

@areshand areshand merged commit ade46e0 into aptos-labs:main Oct 14, 2022
This was referenced Nov 3, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@movekevin movekevin movekevin approved these changes

@MartianSiddharth MartianSiddharth MartianSiddharth approved these changes

@0xchloe 0xchloe 0xchloe approved these changes

@davidiw davidiw Awaiting requested review from davidiw

@lightmark lightmark Awaiting requested review from lightmark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@areshand @0xchloe @MartianSiddharth @movekevin