Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gha] remove unused indexer tests #14823

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

rustielin
Copy link
Contributor

Description

Integration tests are always skipped and also the code was removed here: #14201

Docker-compose based e2e tests likely replaced by Forge, which is more comprehensive. We lose the ability to test the docker-compose, though I don't know how many folks are using that today. It uses local filestore, etc, which diverges from many production deployments of the indexer grpc transaction stream.

How Has This Been Tested?

CI

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@rustielin rustielin requested a review from a team as a code owner October 1, 2024 17:32
Copy link

trunk-io bot commented Oct 1, 2024

⏱️ 1h total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
forge-compat-test / forge 15m 🟩
forge-e2e-test / forge 14m 🟩
rust-doc-tests 5m 🟩
test-target-determinator 4m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
rust-cargo-deny 3m 🟩🟩
check-dynamic-deps 3m 🟩🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
rust-move-tests 2m 🟩
general-lints 54s 🟩🟩
semgrep/ci 46s 🟩🟩
file_change_determinator 27s 🟩🟩
file_change_determinator 11s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 17m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@rustielin rustielin requested a review from a team October 1, 2024 17:41
@rustielin rustielin enabled auto-merge (squash) October 1, 2024 19:20

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Forge suite framework_upgrade success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 6437d9aa7839508c207e5dc47a3c535725b06fdc

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 6437d9aa7839508c207e5dc47a3c535725b06fdc (PR)
Upgrade the nodes to version: 6437d9aa7839508c207e5dc47a3c535725b06fdc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1056.47 txn/s, submitted: 1059.56 txn/s, failed submission: 3.08 txn/s, expired: 3.08 txn/s, latency: 2808.15 ms, (p50: 2400 ms, p70: 3000, p90: 4800 ms, p99: 7300 ms), latency samples: 95900
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 838.67 txn/s, submitted: 840.34 txn/s, failed submission: 1.67 txn/s, expired: 1.67 txn/s, latency: 4575.66 ms, (p50: 2700 ms, p70: 3800, p90: 14700 ms, p99: 16300 ms), latency samples: 70280
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 6437d9aa7839508c207e5dc47a3c535725b06fdc passed
Upgrade the remaining nodes to version: 6437d9aa7839508c207e5dc47a3c535725b06fdc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 854.36 txn/s, submitted: 856.34 txn/s, failed submission: 1.98 txn/s, expired: 1.98 txn/s, latency: 4381.07 ms, (p50: 2700 ms, p70: 3600, p90: 13800 ms, p99: 16200 ms), latency samples: 69060
Test Ok

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Forge suite compat success on 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 6437d9aa7839508c207e5dc47a3c535725b06fdc

Compatibility test results for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 6437d9aa7839508c207e5dc47a3c535725b06fdc (PR)
1. Check liveness of validators at old version: 7ef01a26f8d8a38610e3d364b722df517c970749
compatibility::simple-validator-upgrade::liveness-check : committed: 10864.79 txn/s, latency: 3126.37 ms, (p50: 2100 ms, p70: 2300, p90: 6200 ms, p99: 24200 ms), latency samples: 421700
2. Upgrading first Validator to new version: 6437d9aa7839508c207e5dc47a3c535725b06fdc
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2009.29 txn/s, latency: 14787.36 ms, (p50: 14900 ms, p70: 19400, p90: 21500 ms, p99: 21800 ms), latency samples: 56300
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6274.95 txn/s, latency: 5025.03 ms, (p50: 5000 ms, p70: 5300, p90: 6900 ms, p99: 7300 ms), latency samples: 234680
3. Upgrading rest of first batch to new version: 6437d9aa7839508c207e5dc47a3c535725b06fdc
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7081.69 txn/s, latency: 3979.87 ms, (p50: 4400 ms, p70: 4600, p90: 5100 ms, p99: 5200 ms), latency samples: 131960
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6816.27 txn/s, latency: 4698.58 ms, (p50: 5200 ms, p70: 5400, p90: 5900 ms, p99: 6300 ms), latency samples: 225920
4. upgrading second batch to new version: 6437d9aa7839508c207e5dc47a3c535725b06fdc
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10163.98 txn/s, latency: 2651.04 ms, (p50: 2800 ms, p70: 3000, p90: 3200 ms, p99: 3500 ms), latency samples: 181080
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8294.30 txn/s, latency: 3780.00 ms, (p50: 3300 ms, p70: 3600, p90: 7700 ms, p99: 8900 ms), latency samples: 280020
5. check swarm health
Compatibility test for 7ef01a26f8d8a38610e3d364b722df517c970749 ==> 6437d9aa7839508c207e5dc47a3c535725b06fdc passed
Test Ok

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

✅ Forge suite realistic_env_max_load success on 6437d9aa7839508c207e5dc47a3c535725b06fdc

two traffics test: inner traffic : committed: 13181.65 txn/s, submitted: 13193.33 txn/s, expired: 11.68 txn/s, latency: 2964.15 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 13900 ms), latency samples: 5012060
two traffics test : committed: 100.04 txn/s, latency: 1626.45 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 6100 ms), latency samples: 2000
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.237, avg: 0.222", "QsPosToProposal: max: 1.086, avg: 1.020", "ConsensusProposalToOrdered: max: 0.333, avg: 0.313", "ConsensusOrderedToCommit: max: 0.562, avg: 0.489", "ConsensusProposalToCommit: max: 0.885, avg: 0.802"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.26s no progress at version 24335 (avg 0.23s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.42s no progress at version 2548360 (avg 5.42s) [limit 15].
Test Ok

@rustielin rustielin merged commit 1d89592 into main Oct 2, 2024
91 of 94 checks passed
@rustielin rustielin deleted the rustielin/remove-unused-indexer-tests branch October 2, 2024 17:22
sionescu added a commit that referenced this pull request Oct 2, 2024
sionescu added a commit that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants