Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy indexer integration test crate #14201

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Aug 2, 2024

Description

separated out from this PR: #14148. to remove legacy crate which is not used

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • [X ] Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Aug 2, 2024

⏱️ 4h 1m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 37m 🟥🟥🟩
forge-framework-upgrade-test / forge 34m 🟩🟩
forge-compat-test / forge 31m 🟩🟩
forge-e2e-test / forge 29m 🟩🟩
execution-performance / test-target-determinator 14m 🟩🟩
test-target-determinator 14m 🟩🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
general-lints 8m 🟩🟩🟩🟩🟩
rust-move-tests 8m 🟩
rust-move-tests 8m 🟩
check 7m 🟩🟩
check-dynamic-deps 6m 🟩🟩🟩🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-move-tests 3m
semgrep/ci 2m 🟩🟩🟩🟩🟩
file_change_determinator 1m 🟩🟩🟩🟩🟩
file_change_determinator 55s 🟩🟩🟩🟩🟩
file_change_determinator 26s 🟩🟩
permission-check 12s 🟩🟩🟩🟩🟩
permission-check 12s 🟩🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩
permission-check 6s 🟩🟩
determine-docker-build-metadata 5s 🟩🟩
Backport PR 3s 🟥
permission-check 3s 🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
test-target-determinator 7m 5m +46%
execution-performance / test-target-determinator 7m 5m +39%
execution-performance / single-node-performance 25m 20m +30%

settingsfeedbackdocs ⋅ learn more about trunk.io

@yuunlimm yuunlimm requested a review from a team August 2, 2024 20:08
@yuunlimm yuunlimm force-pushed the yuunlimm/indexer_testing_framework branch from c2971b6 to 834b66b Compare August 2, 2024 20:11
@yuunlimm yuunlimm requested review from banool, bowenyang007 and a team August 2, 2024 20:48
@yuunlimm yuunlimm enabled auto-merge (squash) August 2, 2024 21:03
@yuunlimm yuunlimm disabled auto-merge August 2, 2024 21:03

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@yuunlimm yuunlimm force-pushed the yuunlimm/indexer_testing_framework branch from 834b66b to ebdbf7c Compare August 5, 2024 17:43
@yuunlimm yuunlimm enabled auto-merge (squash) August 5, 2024 22:19

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

✅ Forge suite realistic_env_max_load success on ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5

two traffics test: inner traffic : committed: 11321.56 txn/s, latency: 3514.77 ms, (p50: 3300 ms, p90: 4200 ms, p99: 10200 ms), latency samples: 4304700
two traffics test : committed: 99.94 txn/s, latency: 2881.33 ms, (p50: 2600 ms, p90: 3600 ms, p99: 10100 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.244, avg: 0.229", "QsPosToProposal: max: 0.511, avg: 0.466", "ConsensusProposalToOrdered: max: 0.351, avg: 0.340", "ConsensusOrderedToCommit: max: 0.724, avg: 0.674", "ConsensusProposalToCommit: max: 1.066, avg: 1.014"]
Max round gap was 1 [limit 4] at version 2413197. Max no progress secs was 7.124966 [limit 15] at version 2413197.
Test Ok

Copy link
Contributor

github-actions bot commented Aug 5, 2024

✅ Forge suite compat success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5 (PR)
1. Check liveness of validators at old version: 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5
compatibility::simple-validator-upgrade::liveness-check : committed: 6894.54 txn/s, latency: 4326.58 ms, (p50: 3400 ms, p90: 7200 ms, p99: 19000 ms), latency samples: 266760
2. Upgrading first Validator to new version: ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6658.21 txn/s, latency: 4044.20 ms, (p50: 4200 ms, p90: 5500 ms, p99: 5600 ms), latency samples: 127340
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6736.94 txn/s, latency: 4601.50 ms, (p50: 4700 ms, p90: 7000 ms, p99: 7400 ms), latency samples: 226140
3. Upgrading rest of first batch to new version: ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7298.94 txn/s, latency: 3852.87 ms, (p50: 4400 ms, p90: 4700 ms, p99: 4900 ms), latency samples: 134300
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7537.88 txn/s, latency: 4190.19 ms, (p50: 4300 ms, p90: 5700 ms, p99: 6100 ms), latency samples: 254880
4. upgrading second batch to new version: ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12152.46 txn/s, latency: 2234.04 ms, (p50: 2400 ms, p90: 2500 ms, p99: 2700 ms), latency samples: 212740
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7021.53 txn/s, latency: 3544.87 ms, (p50: 2500 ms, p90: 5500 ms, p99: 17800 ms), latency samples: 354300
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5 passed
Test Ok

Copy link
Contributor

github-actions bot commented Aug 5, 2024

✅ Forge suite framework_upgrade success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5 (PR)
Upgrade the nodes to version: ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1070.29 txn/s, submitted: 1072.83 txn/s, failed submission: 2.54 txn/s, expired: 2.54 txn/s, latency: 2897.35 ms, (p50: 2100 ms, p90: 5400 ms, p99: 10500 ms), latency samples: 92640
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1181.19 txn/s, submitted: 1183.82 txn/s, failed submission: 2.64 txn/s, expired: 2.64 txn/s, latency: 2743.59 ms, (p50: 2100 ms, p90: 4800 ms, p99: 9000 ms), latency samples: 98480
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5 passed
Upgrade the remaining nodes to version: ebdbf7cf29243deb1889d1b75642c2a48cc0e9c5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1411.84 txn/s, submitted: 1414.59 txn/s, failed submission: 2.75 txn/s, expired: 2.75 txn/s, latency: 2667.47 ms, (p50: 2400 ms, p90: 4200 ms, p99: 7700 ms), latency samples: 102840
Test Ok

@yuunlimm yuunlimm merged commit 3ec115d into main Aug 5, 2024
90 checks passed
@yuunlimm yuunlimm deleted the yuunlimm/indexer_testing_framework branch August 5, 2024 22:57
@rustielin rustielin mentioned this pull request Oct 1, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants