Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 01f3324b49313d2e849a651ef065b2fb7dcd8486 onto aptos-indexer-grpc-v1.5 #13606

Conversation

banool
Copy link
Contributor

@banool banool commented Jun 7, 2024

Description

Cherry picking the PR to make the in memory cache configurable.

See https://aptos-org.slack.com/archives/C0468USBLQJ/p1717664804217059.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

See CI.

Key Areas to Review

N/A, already reviewed, just a cherry pick.

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@banool banool requested review from davidiw, movekevin and wrwg as code owners June 7, 2024 10:48
Copy link

trunk-io bot commented Jun 7, 2024

⏱️ 5h 21m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 14m 🟩🟥🟩
rust-unit-tests 47m 🟩
rust-smoke-tests 36m 🟩
rust-move-tests 32m 🟩
run-tests-main-branch 23m 🟩🟩🟩🟩🟩
forge-compat-test / forge 20m 🟩
rust-images / rust-all 19m 🟩
rust-lints 16m 🟩🟩
forge-e2e-test / forge 13m 🟩
cli-e2e-tests / run-cli-tests 10m 🟥
check-dynamic-deps 8m 🟩🟩🟩🟩🟩 (+1 more)
rust-build-cached-packages 5m 🟩
general-lints 5m 🟩🟩
check 4m 🟥
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 2m 🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩 (+1 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩
file_change_determinator 58s 🟩🟩🟩🟩
file_change_determinator 55s 🟩🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 53s 🟩
execution-performance / file_change_determinator 45s 🟩🟩🟩
permission-check 21s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 21s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 19s 🟩🟩🟩🟩 (+1 more)
permission-check 18s 🟩🟩🟩🟩 (+1 more)
file_change_determinator 12s 🟩
permission-check 4s 🟩
determine-docker-build-metadata 1s 🟩

🚨 4 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 16m 9m +86%
forge-compat-test / forge 20m 13m +57%
cli-e2e-tests / run-cli-tests 10m 6m +52%
rust-images / rust-all 19m 14m +37%

settingsfeedbackdocs ⋅ learn more about trunk.io

@banool banool changed the base branch from main to aptos-indexer-grpc-v1.5 June 7, 2024 10:48
@banool banool force-pushed the banool/cherrry-pick-01f3324b49313d2e849a651ef065b2fb7dcd8486 branch 2 times, most recently from da138ec to 6dad19e Compare June 7, 2024 10:52
@banool banool force-pushed the banool/cherrry-pick-01f3324b49313d2e849a651ef065b2fb7dcd8486 branch from 6dad19e to e66f866 Compare June 7, 2024 10:53
@banool banool added CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR CICD:build-indexer-images CICD:run-all-unit-tests Runs all unit tests labels Jun 7, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

✅ Forge suite realistic_env_max_load success on e66f866785774c2b57ff92d8ff62b3c2b5ff500d

two traffics test: inner traffic : committed: 8322 txn/s, latency: 4719 ms, (p50: 4500 ms, p90: 5400 ms, p99: 9600 ms), latency samples: 3587160
two traffics test : committed: 100 txn/s, latency: 1873 ms, (p50: 1800 ms, p90: 2100 ms, p99: 4000 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.203", "QsPosToProposal: max: 0.247, avg: 0.232", "ConsensusProposalToOrdered: max: 0.412, avg: 0.398", "ConsensusOrderedToCommit: max: 0.336, avg: 0.323", "ConsensusProposalToCommit: max: 0.732, avg: 0.721"]
Max round gap was 1 [limit 4] at version 1801288. Max no progress secs was 4.879659 [limit 15] at version 1801288.
Test Ok

Copy link
Contributor

github-actions bot commented Jun 7, 2024

✅ Forge suite compat success on aptos-node-v1.10.1 ==> e66f866785774c2b57ff92d8ff62b3c2b5ff500d

Compatibility test results for aptos-node-v1.10.1 ==> e66f866785774c2b57ff92d8ff62b3c2b5ff500d (PR)
1. Check liveness of validators at old version: aptos-node-v1.10.1
compatibility::simple-validator-upgrade::liveness-check : committed: 6002 txn/s, latency: 5484 ms, (p50: 5100 ms, p90: 8600 ms, p99: 12100 ms), latency samples: 210080
2. Upgrading first Validator to new version: e66f866785774c2b57ff92d8ff62b3c2b5ff500d
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1803 txn/s, latency: 16027 ms, (p50: 18700 ms, p90: 22500 ms, p99: 22700 ms), latency samples: 91960
3. Upgrading rest of first batch to new version: e66f866785774c2b57ff92d8ff62b3c2b5ff500d
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1716 txn/s, latency: 16753 ms, (p50: 19000 ms, p90: 22200 ms, p99: 22600 ms), latency samples: 89260
4. upgrading second batch to new version: e66f866785774c2b57ff92d8ff62b3c2b5ff500d
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3464 txn/s, latency: 8640 ms, (p50: 9900 ms, p90: 11600 ms, p99: 12200 ms), latency samples: 145500
5. check swarm health
Compatibility test for aptos-node-v1.10.1 ==> e66f866785774c2b57ff92d8ff62b3c2b5ff500d passed
Test Ok

@banool banool merged commit fb46797 into aptos-indexer-grpc-v1.5 Jun 7, 2024
106 of 112 checks passed
@banool banool deleted the banool/cherrry-pick-01f3324b49313d2e849a651ef065b2fb7dcd8486 branch June 7, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-indexer-images CICD:run-all-unit-tests Runs all unit tests CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant