-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data service] Add support for configuring in memory cache size #13570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banool
force-pushed
the
banool/data-service-cache-size
branch
2 times, most recently
from
June 5, 2024 13:47
cbc2c93
to
044f189
Compare
banool
force-pushed
the
banool/data-service-cache-size
branch
from
June 5, 2024 13:47
044f189
to
2ad040c
Compare
rustielin
approved these changes
Jun 5, 2024
larry-aptos
approved these changes
Jun 5, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
banool
added a commit
that referenced
this pull request
Jun 7, 2024
banool
added a commit
that referenced
this pull request
Jun 7, 2024
21 tasks
banool
added a commit
that referenced
this pull request
Jun 7, 2024
banool
added a commit
that referenced
this pull request
Jun 7, 2024
banool
added a commit
that referenced
this pull request
Jun 7, 2024
banool
added a commit
that referenced
this pull request
Jun 7, 2024
aluon
pushed a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to be able to tune the value of the in memory cache for data service. This PR adds support for that.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
For now, just see that the existing tests pass:
Key Areas to Review
Make sure I'm not missing any spot we might need to change.
Checklist