Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collection address, old and new values to collection mutation events #12807

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

JohnChangUK
Copy link
Member

Description

Add additional fields in Collection mutation events for indexing needs. Follow up from PR: #12737

  1. Changing the collection name
    • Emit the collection object address, as well as the old and new values
  2. Changing the collection max supply
    • Emit the old max supply too

Copy link

trunk-io bot commented Apr 5, 2024

⏱️ 7h 47m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 1h 29m 🟩🟩
rust-smoke-tests 56m 🟩
execution-performance / single-node-performance 44m 🟩🟩
windows-build 41m 🟩🟩
rust-move-tests 41m 🟩🟩🟩🟩
rust-move-unit-coverage 33m 🟩
rust-images / rust-all 27m 🟩🟩
rust-lints 22m 🟩🟩🟩🟩
forge-e2e-test / forge 21m 🟩
forge-compat-test / forge 19m 🟩
run-tests-main-branch 17m 🟩🟩🟩🟩
cli-e2e-tests / run-cli-tests 16m 🟩
general-lints 9m 🟩🟩🟩🟩
rust-build-cached-packages 8m 🟩🟩
check-dynamic-deps 8m 🟩🟩🟩🟩
check 8m 🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 58s 🟩🟩🟩🟩
file_change_determinator 56s 🟩🟩🟩🟩
file_change_determinator 43s 🟩🟩🟩
file_change_determinator 25s 🟩🟩
execution-performance / file_change_determinator 24s 🟩🟩
permission-check 15s 🟩🟩🟩
permission-check 12s 🟩🟩🟩
permission-check 10s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
determine-docker-build-metadata 6s 🟩🟩
permission-check 5s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@JohnChangUK JohnChangUK requested a review from bowenyang007 April 5, 2024 14:51
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.6%. Comparing base (7b01dfa) to head (9815e18).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12807   +/-   ##
=======================================
  Coverage    62.6%    62.6%           
=======================================
  Files         821      821           
  Lines      184167   184167           
=======================================
  Hits       115385   115385           
  Misses      68782    68782           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lightmark lightmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@BriungRi BriungRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these incompatible changes?

@JohnChangUK JohnChangUK enabled auto-merge (squash) April 5, 2024 17:36
@JohnChangUK JohnChangUK disabled auto-merge April 5, 2024 17:36
@JohnChangUK
Copy link
Member Author

Aren't these incompatible changes?

They are yes. Hence I want to get this in before mainnet

This comment has been minimized.

This comment has been minimized.

@JohnChangUK JohnChangUK enabled auto-merge (squash) April 5, 2024 17:57

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

✅ Forge suite compat success on aptos-node-v1.10.1 ==> 9815e18580471353eeefe93a2ba0a5c0af4c1689

Compatibility test results for aptos-node-v1.10.1 ==> 9815e18580471353eeefe93a2ba0a5c0af4c1689 (PR)
1. Check liveness of validators at old version: aptos-node-v1.10.1
compatibility::simple-validator-upgrade::liveness-check : committed: 6996 txn/s, latency: 4726 ms, (p50: 4800 ms, p90: 7200 ms, p99: 7800 ms), latency samples: 244860
2. Upgrading first Validator to new version: 9815e18580471353eeefe93a2ba0a5c0af4c1689
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1875 txn/s, latency: 15616 ms, (p50: 18600 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 91880
3. Upgrading rest of first batch to new version: 9815e18580471353eeefe93a2ba0a5c0af4c1689
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1819 txn/s, latency: 15995 ms, (p50: 18400 ms, p90: 22900 ms, p99: 23200 ms), latency samples: 90980
4. upgrading second batch to new version: 9815e18580471353eeefe93a2ba0a5c0af4c1689
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3448 txn/s, latency: 8645 ms, (p50: 9900 ms, p90: 11400 ms, p99: 12100 ms), latency samples: 144840
5. check swarm health
Compatibility test for aptos-node-v1.10.1 ==> 9815e18580471353eeefe93a2ba0a5c0af4c1689 passed
Test Ok

Copy link
Contributor

github-actions bot commented Apr 5, 2024

✅ Forge suite realistic_env_max_load success on 9815e18580471353eeefe93a2ba0a5c0af4c1689

two traffics test: inner traffic : committed: 8409 txn/s, latency: 4670 ms, (p50: 4500 ms, p90: 5400 ms, p99: 9900 ms), latency samples: 3624320
two traffics test : committed: 100 txn/s, latency: 1867 ms, (p50: 1800 ms, p90: 2000 ms, p99: 7100 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.202", "QsPosToProposal: max: 0.226, avg: 0.220", "ConsensusProposalToOrdered: max: 0.417, avg: 0.399", "ConsensusOrderedToCommit: max: 0.348, avg: 0.338", "ConsensusProposalToCommit: max: 0.747, avg: 0.737"]
Max round gap was 1 [limit 4] at version 1773935. Max no progress secs was 4.675082 [limit 15] at version 1773935.
Test Ok

@JohnChangUK JohnChangUK merged commit 4a10bed into main Apr 5, 2024
123 of 128 checks passed
@JohnChangUK JohnChangUK deleted the john/event-change branch April 5, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants