-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cherry pick] Allow to set the beneficiary for operator #11032
Merged
sherry-x
merged 3 commits into
aptos-release-v1.8
from
jpark/cherry-pick-operator-beneficiary-change
Nov 22, 2023
Merged
[Cherry pick] Allow to set the beneficiary for operator #11032
sherry-x
merged 3 commits into
aptos-release-v1.8
from
jpark/cherry-pick-operator-beneficiary-change
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkil-park
requested review from
davidiw,
movekevin and
wrwg
as code owners
November 21, 2023 21:29
movekevin
approved these changes
Nov 21, 2023
igor-aptos
approved these changes
Nov 21, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Updated `distribute_internal` to use `aptos_account::deposit_coins` instead of `coin::deposit` * Allows operators to set beneficiaries
This enables OPERATOR_BENEFICIARY_CHANGE in the devent to release (v1.8.4).
junkil-park
force-pushed
the
jpark/cherry-pick-operator-beneficiary-change
branch
from
November 22, 2023 01:03
3b60042
to
799425a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-picks:
OPERATOR_BENEFICIARY_CHANGE
in devnet by default EnablesOPERATOR_BENEFICIARY_CHANGE
in devnet by default #11029This PR also cherry-picks the following PR to enable
LIMIT_MAX_IDENTIFIER_LENGTH
. This was missing in the v1.8.0 branch cut, so we enabled it manually in the devnet at that time.LIMIT_MAX_IDENTIFIER_LENGTH
in devnet by default #10861