Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry pick] Allow to set the beneficiary for operator #11032

Merged

Conversation

junkil-park
Copy link
Contributor

@junkil-park junkil-park commented Nov 21, 2023

Description

This PR cherry-picks:

This PR also cherry-picks the following PR to enable LIMIT_MAX_IDENTIFIER_LENGTH. This was missing in the v1.8.0 branch cut, so we enabled it manually in the devnet at that time.

@sherry-x sherry-x enabled auto-merge (squash) November 21, 2023 21:50

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

junkil-park and others added 3 commits November 21, 2023 17:02
* Updated `distribute_internal` to use `aptos_account::deposit_coins` instead of `coin::deposit`

* Allows operators to set beneficiaries
This enables OPERATOR_BENEFICIARY_CHANGE in the devent to release (v1.8.4).

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 799425a2f351aeafce59ca9959c60ae783a51dad

two traffics test: inner traffic : committed: 6391 txn/s, latency: 6119 ms, (p50: 5700 ms, p90: 8100 ms, p99: 11700 ms), latency samples: 2773820
two traffics test : committed: 100 txn/s, latency: 2509 ms, (p50: 2300 ms, p90: 2900 ms, p99: 8100 ms), latency samples: 1860
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.231, avg: 0.212", "QsPosToProposal: max: 0.160, avg: 0.152", "ConsensusProposalToOrdered: max: 0.614, avg: 0.589", "ConsensusOrderedToCommit: max: 0.525, avg: 0.504", "ConsensusProposalToCommit: max: 1.117, avg: 1.093"]
Max round gap was 1 [limit 4] at version 1237677. Max no progress secs was 3.474726 [limit 10] at version 1237677.
Test Ok

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.7.3 ==> 799425a2f351aeafce59ca9959c60ae783a51dad

Compatibility test results for aptos-node-v1.7.3 ==> 799425a2f351aeafce59ca9959c60ae783a51dad (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 3396 txn/s, latency: 6758 ms, (p50: 6900 ms, p90: 9600 ms, p99: 11700 ms), latency samples: 180020
2. Upgrading first Validator to new version: 799425a2f351aeafce59ca9959c60ae783a51dad
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1772 txn/s, latency: 16051 ms, (p50: 19100 ms, p90: 22000 ms, p99: 22500 ms), latency samples: 92180
3. Upgrading rest of first batch to new version: 799425a2f351aeafce59ca9959c60ae783a51dad
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1848 txn/s, latency: 15648 ms, (p50: 19700 ms, p90: 21900 ms, p99: 22300 ms), latency samples: 92420
4. upgrading second batch to new version: 799425a2f351aeafce59ca9959c60ae783a51dad
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3248 txn/s, latency: 9739 ms, (p50: 10000 ms, p90: 13300 ms, p99: 14100 ms), latency samples: 139700
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 799425a2f351aeafce59ca9959c60ae783a51dad passed
Test Ok

@sherry-x sherry-x merged commit 8beaf59 into aptos-release-v1.8 Nov 22, 2023
40 checks passed
@sherry-x sherry-x deleted the jpark/cherry-pick-operator-beneficiary-change branch November 22, 2023 01:37
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> 799425a2f351aeafce59ca9959c60ae783a51dad

Compatibility test results for aptos-node-v1.7.3 ==> 799425a2f351aeafce59ca9959c60ae783a51dad (PR)
Upgrade the nodes to version: 799425a2f351aeafce59ca9959c60ae783a51dad
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4824 txn/s, latency: 6687 ms, (p50: 6600 ms, p90: 9900 ms, p99: 11600 ms), latency samples: 183320
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 799425a2f351aeafce59ca9959c60ae783a51dad passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants