Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables OPERATOR_BENEFICIARY_CHANGE in devnet by default #11029

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Enables OPERATOR_BENEFICIARY_CHANGE in devnet by default #11029

merged 1 commit into from
Nov 21, 2023

Conversation

junkil-park
Copy link
Contributor

@junkil-park junkil-park commented Nov 21, 2023 •
edited
Loading

Description

This enables OPERATOR_BENEFICIARY_CHANGE in the devnet to release (v1.8.4).

@junkil-park
Enables OPERATOR_BENEFICIARY_CHANGE in devent by default
3785156 
This enables `OPERATOR_BENEFICIARY_CHANGE` in the devent to release (v1.8.4).
junkil-park added a commit that referenced this pull request Nov 21, 2023
@junkil-park
Update lib.rs (#11029)
3b60042 
This enables OPERATOR_BENEFICIARY_CHANGE in the devent to release (v1.8.4).
@junkil-park junkil-park changed the title Enables OPERATOR_BENEFICIARY_CHANGE in devent by default Enables OPERATOR_BENEFICIARY_CHANGE in devnet by default Nov 21, 2023
@junkil-park junkil-park mentioned this pull request Nov 21, 2023
Merged
@sherry-x
Copy link
Contributor

sherry-x commented Nov 21, 2023 •
edited
Loading

unless this one is getting cherry-picked also into release branch, it won't impact devnet cause tomorrow we're going to deploy devnet from release 1.8 branch. but I guess we will eventually need this as soon as we get this feature enabled with next 1.8.x release

@junkil-park
Copy link
Contributor Author

junkil-park commented Nov 21, 2023 •
edited
Loading

unless this one is getting cherry-picked also into release branch, it won't impact devnet cause tomorrow we're going to deploy devnet from release 1.8 branch. but I guess we will eventually need this as soon as we get this feature enabled with next 1.8.x release

Right, this will make the feature enabled in some CI tests. This PR is going to be cherry-picked in the 1.8 branch as well (in #11032).

perryjrandall
perryjrandall approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@perryjrandall perryjrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yess

@junkil-park junkil-park enabled auto-merge (squash) November 21, 2023 23:18
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.7.3 ==> 378515661a5a781699f0259c959775b41b4d5e8d

Compatibility test results for aptos-node-v1.7.3 ==> 378515661a5a781699f0259c959775b41b4d5e8d (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 5043 txn/s, latency: 6586 ms, (p50: 6900 ms, p90: 9600 ms, p99: 10500 ms), latency samples: 186620
2. Upgrading first Validator to new version: 378515661a5a781699f0259c959775b41b4d5e8d
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1781 txn/s, latency: 15670 ms, (p50: 19500 ms, p90: 21700 ms, p99: 22300 ms), latency samples: 92620
3. Upgrading rest of first batch to new version: 378515661a5a781699f0259c959775b41b4d5e8d
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1783 txn/s, latency: 15835 ms, (p50: 19300 ms, p90: 21800 ms, p99: 22600 ms), latency samples: 92760
4. upgrading second batch to new version: 378515661a5a781699f0259c959775b41b4d5e8d
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3684 txn/s, latency: 8711 ms, (p50: 9900 ms, p90: 12300 ms, p99: 12600 ms), latency samples: 143700
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 378515661a5a781699f0259c959775b41b4d5e8d passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 378515661a5a781699f0259c959775b41b4d5e8d

two traffics test: inner traffic : committed: 8364 txn/s, latency: 4698 ms, (p50: 4500 ms, p90: 5600 ms, p99: 10500 ms), latency samples: 3605020
two traffics test : committed: 100 txn/s, latency: 2346 ms, (p50: 2200 ms, p90: 2800 ms, p99: 6400 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.216, avg: 0.198", "QsPosToProposal: max: 0.173, avg: 0.146", "ConsensusProposalToOrdered: max: 0.607, avg: 0.564", "ConsensusOrderedToCommit: max: 0.493, avg: 0.468", "ConsensusProposalToCommit: max: 1.083, avg: 1.033"]
Max round gap was 1 [limit 4] at version 1659647. Max no progress secs was 4.39842 [limit 10] at version 1659647.
Test Ok

@junkil-park junkil-park merged commit bf75f97 into main Nov 21, 2023
87 checks passed
@junkil-park junkil-park deleted the jpark/enable-operator-beneficiary-change branch November 21, 2023 23:49
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> 378515661a5a781699f0259c959775b41b4d5e8d

Compatibility test results for aptos-node-v1.7.3 ==> 378515661a5a781699f0259c959775b41b4d5e8d (PR)
Upgrade the nodes to version: 378515661a5a781699f0259c959775b41b4d5e8d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 7046 txn/s, latency: 4816 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8400 ms), latency samples: 246640
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 378515661a5a781699f0259c959775b41b4d5e8d passed
Test Ok

junkil-park added a commit that referenced this pull request Nov 22, 2023
@junkil-park
Update lib.rs (#11029)
799425a 
This enables OPERATOR_BENEFICIARY_CHANGE in the devent to release (v1.8.4).
sherry-x pushed a commit that referenced this pull request Nov 22, 2023
@junkil-park
[Cherry pick] Allow to set the beneficiary for operator (#11032)
8beaf59 
* [Stake] Allow to set the beneficiary for operator (#10455)

* Updated `distribute_internal` to use `aptos_account::deposit_coins` instead of `coin::deposit`

* Allows operators to set beneficiaries

* Update lib.rs (#10861)

* Update lib.rs (#11029)

This enables OPERATOR_BENEFICIARY_CHANGE in the devent to release (v1.8.4).
bowenyang007 pushed a commit that referenced this pull request Dec 7, 2023
@junkil-park @bowenyang007
Enables OPERATOR_BENEFICIARY_CHANGE in devent by default (#11029)
5b69078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherry-x sherry-x sherry-x approved these changes

@perryjrandall perryjrandall perryjrandall approved these changes

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junkil-park @sherry-x @perryjrandall