-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically create PR to bump homebrew version of CLI, don't build MacOS binary #10814
Conversation
83a2ee2
to
2ac0587
Compare
ddd75d1
to
d3ed481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to update the doc page for CLI installation as well / any other scripts that use it.
Alternatively for now we could just build the x86 one and communicate it accordingly
I'd say we should not build MacOS at all ourselves, it's just confusing. Better to mandate brew imo. Or if we do build it, we should build a universal binary. |
d3ed481
to
74f4c2a
Compare
74f4c2a
to
ca46013
Compare
Yes, this is similar to how the Linux build is also confusing if you're trying to use it elsewhere |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please mandate brew. TBH with the previous openSSL stuff and managing all of those dependency without brew was a real pain.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Description
We've learned in the last few months that brew isn't as magic as I thought and every time we release a CLI, someone actually creates a PR to bump the version in homebrew-core manually. This means sometimes it can take a while.
To make this process faster, this PR adds a step to the CLI release that submits that version bump PR automatically.
Test Plan
This PR was opened thanks to the new job added here: Homebrew/homebrew-core#153591.