Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aptos aptos-cli-v2.3.1 #153591

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

aptos-bot
Copy link
Contributor

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@banool banool mentioned this pull request Nov 7, 2023
@banool
Copy link
Contributor

banool commented Nov 7, 2023

I'm not sure why this build is failing, the commit it refers to exists: aptos-labs/aptos-core@14c8813.

@banool
Copy link
Contributor

banool commented Nov 7, 2023

SO implies this is due to a faulty registry, though idk if brew does any caching in their build pipeline: https://stackoverflow.com/questions/41093530/cargo-build-results-in-no-match-for-id.

I wonder if the depth of repo cloning is the issue. When you build the CLI in aptos-core, it depends on the processor crate from aptos-indexer-processors, which depends on the aptos-protos crate in aptos-core. We never have issues with this in our own build pipeline but maybe brew has a different setup.

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 7, 2023
@banool
Copy link
Contributor

banool commented Nov 7, 2023

The jobs that failed before and after the label are different, could this be a problem with the brew build environment? Everything I see implies that this error is due to some kind of bad cache.

@banool
Copy link
Contributor

banool commented Nov 8, 2023

@chenrui333 could you please re run the failing job? It seems like it must be transient because the same job passes on MacOS 12 and MacOS 14 on x86.

@banool
Copy link
Contributor

banool commented Nov 8, 2023

cc @p-linnane who helped me with the aptos formula last time.

@chenrui333
Copy link
Member

@chenrui333 could you please re run the failing job? It seems like it must be transient because the same job passes on MacOS 12 and MacOS 14 on x86.

yeah, i saw it, it would be yank the release and create a new one next time.

rerunning the job now

Copy link
Contributor

github-actions bot commented Nov 8, 2023

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 8, 2023
@BrewTestBot BrewTestBot enabled auto-merge November 8, 2023 15:03
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 8, 2023
Merged via the queue into Homebrew:master with commit 27cae64 Nov 8, 2023
12 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants