Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on Eric's efforts. #331

Closed
wants to merge 8 commits into from
Closed

Build on Eric's efforts. #331

wants to merge 8 commits into from

Conversation

UserNotFound
Copy link
Member

Building on Eric's efforts:

  • Added the Gemfile.lock, otherwise the Compose volume mount overwrites (effectively deletes) the lock created during build (which would have the effect of forcing you to bundle install again the first time you use the container)
  • Use a simpler method for reverting to an older Bundler version (1.17.3)
  • install dependencies before copying code, to avoid rebuilding the bundle install layer every time you edit code
  • Mount your current tokens, rather than requiring you to set it via ENV
  • Add a Makefile with common actions
  • Set a CMD that works (though still not useful unless you mount a volume or pass creds via ENV)
  • added a Dockerignore to keep the image tidy.

@UserNotFound UserNotFound changed the base branch from sc-24724-config-get to master May 28, 2024 15:07
@neurosnap
Copy link
Member

Resolved conflicts in #333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants