-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aptible config:get
cmd
#330
Conversation
feat: dockerfile for local dev
Tested, and LGTM. Behavior matches
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY!
@@ -0,0 +1,10 @@ | |||
services: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this (and the Dockerfile)! It is probably worth adding a quick note to the README about how to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@UserNotFound has a followup PR #331 where we can polish the local docker development -- where we can add a README update, I probably should have made a separate PR for it.
COPY . /app | ||
|
||
RUN ./cleanup_bundler | ||
RUN gem install bundler -v '< 2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I needed to RUN rm -f Gemfile.lock
here to avoid:
=> [5/6] RUN gem install bundler -v '< 2' 12.0s
=> ERROR [6/6] RUN bundle install 0.2s
------
> [6/6] RUN bundle install:
#0 0.227 /usr/local/lib/ruby/2.7.0/rubygems.rb:277:in `find_spec_for_exe': Could not find 'bundler' (2.1.4) required by your /app/Gemfile.lock. (Gem::GemNotFoundException)
https://app.shortcut.com/aptible/story/24724/aptible-config-get-to-retrieve-single-env-variable-value
I also added some docker files to make local development easier