Cache rework Stage I #5088
Merged
Cache rework Stage I #5088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass over the code to quickly put in place a cache with entries that use temporary files and atomic rename to finalize. Modified the actions / pull / registry / build code to call it. WIP - Tests will not work. Cache management commands will not work.
Specific cache list not yet implemented
cclerget
requested changes
Mar 6, 2020
| } | ||
| if foundMatch { | ||
| matches++ | ||
| /* |
There was a problem hiding this comment.
Is it something to remove or pending for the next PR ?
There was a problem hiding this comment.
I wanted to return this when I refactor the clean and list stuff so that the operations are in the cache code, not CLI, in a following cleanup.
There was a problem hiding this comment.
I'll make an issue so this is note missed - https://github.com/sylabs/singularity/issues/5095
This was referenced Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 1st step toward reworking the cache / image source client code to reduce duplication and make operations that fetch things into the cache safe where multiple operations are run concurrently on a file system that supports atomic rename.
Fixes: #4015
Fixes: #5020
This PR does...
pkg/internal/client/cachetopkg/internal/cacheas it's used by the clients, but also other code, and is not a client itself.pkg/internal/client/*pull,actionsand inbuild/sourcespullactionsbuild- prior to this some things like net weren't caching in some of these.--quietand is used across the client code.Future work
This PR is getting rather large, so instead of making it ever bigger I'd like to put up additional PRs over the next week to address the following:
The
pkg/image/client/xxxcode is just a collection of functions per client, mostly duplicated and named consistently, but with varying and long function sigs. Refactor so there is a commonclient.Configstruct, and specific clients implement a commonclient.Pullerandclient.Pusherinterfaces.REGRESSION - CTRL-C handlers have been stripped out. They need to be added back in, but using contexts with cancellation so that actions to cleanup happen close to the code creating files.
The
cache listandcache cleancode needs to be properly refactored so that things directly acting on cache directories are inpkg/internal/cacheand not throughout the CLI code.