Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to run previously cached library image after #5088 #5097

Closed
dtrudg opened this issue Mar 6, 2020 · 0 comments · Fixed by #5098
Closed

Failure to run previously cached library image after #5088 #5097

dtrudg opened this issue Mar 6, 2020 · 0 comments · Fixed by #5098
Assignees
@dtrudg
Labels
Regression Issues which describes regressions in Singularity Urgent
Milestone
3.6.0

Comments

@dtrudg
Copy link
Contributor

dtrudg commented Mar 6, 2020

Version of Singularity:

What version of Singularity are you using? master

Actual behavior

After #5088 if there is an old directory entry for an image in the cache then Singularity will attempt to run against the directory, and fail. I the new cache format cache entries are files. We need to detect a directory, remove it, re-cache.

dave@piran~/.s/c/library> mkdir sha256.02ee8bf9dc335c244f8af97b901c5f62506e687ed54a8adc940d5996266dd344
dave@piran~/.s/c/library> cd
dave@piran~> singularity run library://ubuntu
INFO:    Using cached image
WARNING: passwd file doesn't exist in container, not updating
WARNING: group file doesn't exist in container, not updating
ERROR:   No runscript and no /bin/sh executable found in container, aborting

This is my bad :-( I had previous code to handle this but lost the local commit during my work on #5088.
@dtrudg dtrudg self-assigned this Mar 6, 2020
@dtrudg dtrudg added Regression Issues which describes regressions in Singularity Urgent labels Mar 6, 2020
@dtrudg dtrudg added this to the 3.6.0 milestone Mar 6, 2020
@dtrudg dtrudg mentioned this issue Mar 6, 2020
Merged
dtrudg added a commit that referenced this issue Mar 6, 2020
@dtrudg
Handle existing old-style cache entry directories (#5098)
72b09f2 
Fixes: #5097

Also moves defer statements after error checks when getting a cacheEntry
to avoid panics on tmpCleanup with a nil cacheEntry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtrudg dtrudg

Labels
Regression Issues which describes regressions in Singularity Urgent
Projects
None yet
Milestone
3.6.0
Development

Successfully merging a pull request may close this issue.

Handle existing old-style cache entry directories
1 participant
@dtrudg