Only instrument fs with parent span
#817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ All good! |
unflxw
force-pushed
the
fs-create-hook-parent-span
branch
from
af900e2 to
3cb4355
Compare
luismiramirez
approved these changes
Dec 28, 2022
To avoid having spans consisting entirely of an `fs` invocation, such as those originating from reading files on boot, only instrument `fs` calls if there already is a root span.
unflxw
force-pushed
the
fs-create-hook-parent-span
branch
from
3cb4355 to
7637610
Compare
jeffkreeftmeijer
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #813.
After implementing the OTel PR with the
requireParentSpanconfiguration option, while ungarbling the README file in order to document it, I realised that there was an easy way to do this already available within the instrumentation. 🤦This is that easy way. It might be good to replace this with
requireParentSpanonce/if it's merged, but it's merely a nice-to-have.