Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement requireParentSpan for fs instrumentation #813

Closed
unflxw opened this issue Dec 15, 2022 · 1 comment · Fixed by #817
Closed

Implement requireParentSpan for fs instrumentation #813

unflxw opened this issue Dec 15, 2022 · 1 comment · Fixed by #817
Assignees

Comments

@unflxw
Copy link
Contributor

unflxw commented Dec 15, 2022

Other OTel instrumentations (such as Mongoose) have a requireParentSpan option. When active, they will only create a span if there's already an active span in the current context that can be their span's parent -- that is, their span will never be the root span.

This could be useful in reducing noise in our users' dashboards, as users' applications and libraries often read files at points which are not already in an instrumentation context. A trace consisting only of "fs openFile" every time you boot your app is not particularly useful to the user.

@unflxw unflxw self-assigned this Dec 27, 2022
@unflxw
Copy link
Contributor Author

unflxw commented Dec 27, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant