Always set the route path to empty if not specified #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the CRD is now too long, and 'apply' will refuse to create it. Apply adds the whole resource as annotation, but create doesn't
As otherwise a previous path may continue to exist in the route, even if it has been removed from the spec
leochr
approved these changes
Apr 11, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As otherwise a previous path may continue to exist in the route, even if it has been removed from the spec
This is to deal with part of the problem raised in issue #299
When this is merged, the OpenLiberty operator will need to pick up the latest utils, to fix the similar issue
OpenLiberty/open-liberty-operator#363