Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route path is not removed when path line is deleted #363

Closed
6 tasks done
danielguinan1 opened this issue Aug 31, 2022 · 4 comments
Closed
6 tasks done

Route path is not removed when path line is deleted #363

danielguinan1 opened this issue Aug 31, 2022 · 4 comments
Assignees
Labels
23004 bug Something isn't working zenhub-dev

Comments

@danielguinan1
Copy link

danielguinan1 commented Aug 31, 2022

Bug Report

What did you do?

when deleting this part of the route in the OpenLibertyApplication yaml

route:
    path: /daytrader

the route does not change to remove the path unless I delete the route.

What did you expect to see?

I expected to see the route path removed.

What did you see instead?

The route path stayed the same as if the path was not deleted.

Environment

  • OpenShift version information (if applicable):

4.10.3

Possible solution

operator could check if path is not present (nil) and then set Route path to /

Additional context

Very minor issue, but if I specify the path in the OLA yaml then edit it removing the path line it does not update the route unless it is deleted. If I change it to path: / or path: "" it removes the path from the route. By default the yaml has expose: true but no path set.

  • RCO
    • Fixed
    • Added tests
  • OLO
    • Fixed
    • Added tests
  • WLO
    • Fixed
    • Added tests
@leochr
Copy link
Member

leochr commented Jan 23, 2023

Same as the following issue on RCO's backlog: application-stacks/runtime-component-operator#299

@leochr
Copy link
Member

leochr commented Apr 19, 2023

@danielguinan1 This should now be fixed for all 3 Operators

@leochr
Copy link
Member

leochr commented Apr 19, 2023

@idlewis please add the tests for OLO and WLO when you get a chance. Thank you

@leochr
Copy link
Member

leochr commented Mar 8, 2024

Closing as completed

@leochr leochr closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
23004 bug Something isn't working zenhub-dev
Projects
None yet
Development

No branches or pull requests

3 participants