Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CI checkout directory from main to swift-protobuf and update tools version in PluginExamples Package.swift #1689

Merged
merged 3 commits into from
Aug 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
path: main
path: swift-protobuf
gjcairo marked this conversation as resolved.
Show resolved Hide resolved
- name: Update and install dependencies
# dependencies from https://github.com/protocolbuffers/protobuf/blob/main/src/README.md
# this step is run before get-sha because we need curl and jq for get-sha
Expand All @@ -62,10 +62,10 @@ jobs:
;;
esac
- name: Build
working-directory: main
working-directory: swift-protobuf
run: make build ${{ matrix.swift.hook }}
- name: Test runtime
working-directory: main
working-directory: swift-protobuf
run: make test-runtime ${{ matrix.swift.hook }}
- name: Cache protobuf
id: cache-protobuf
Expand Down Expand Up @@ -97,16 +97,16 @@ jobs:
NUM_CPUS=$(getconf _NPROCESSORS_ONLN)
make -j "${NUM_CPUS}" protoc conformance_test_runner
- name: Test plugin
working-directory: main
working-directory: swift-protobuf
run: make test-plugin PROTOC=../protobuf/cmake_build/protoc
- name: Test conformance
working-directory: main
working-directory: swift-protobuf
run: make test-conformance CONFORMANCE_TEST_RUNNER=../protobuf/cmake_build/conformance_test_runner
- name: Test SPM plugin
working-directory: main
working-directory: swift-protobuf
run: make test-spm-plugin PROTOC=../protobuf/cmake_build/protoc
- name: Compilation Tests
working-directory: main
working-directory: swift-protobuf
run: make compile-tests PROTOC=../protobuf/cmake_build/protoc

api-breakage:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check_upstream_protos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
path: main
path: swift-protobuf
- name: Checkout protobufbuffers/protobuf
uses: actions/checkout@v4
with:
repository: protocolbuffers/protobuf
path: protobuf
- name: Check Upstream Proto Files
working-directory: main
working-directory: swift-protobuf
run: make check-proto-files
6 changes: 3 additions & 3 deletions .github/workflows/regular_conformance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
path: main
path: swift-protobuf
- name: Update and install dependencies
# dependencies from https://github.com/protocolbuffers/protobuf/blob/main/src/README.md
# this step is run before get-sha because we need curl and jq for get-sha
Expand All @@ -71,7 +71,7 @@ jobs:
with:
path: protobuf
# NOTE: for refs that can float like 'main' the cache might be out of date!
key: ${{ runner.os }}-${{ matrix.swift}}-protobuf-${{ steps.get-sha.outputs.sha }}
key: ${{ runner.os }}-${{ matrix.swift }}-protobuf-${{ steps.get-sha.outputs.sha }}
- name: Checkout protobuf repo
if: steps.cache-protobuf.outputs.cache-hit != 'true'
uses: actions/checkout@v4
Expand All @@ -95,5 +95,5 @@ jobs:
NUM_CPUS=$(getconf _NPROCESSORS_ONLN)
make -j "${NUM_CPUS}" protoc conformance_test_runner
- name: Test conformance
working-directory: main
working-directory: swift-protobuf
run: make test-conformance CONFORMANCE_TEST_RUNNER=../protobuf/cmake_build/conformance_test_runner
4 changes: 2 additions & 2 deletions PluginExamples/Package.swift
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
// swift-tools-version: 5.6
// swift-tools-version: 5.8

import PackageDescription

let package = Package(
name: "PluginExamples",
dependencies: [
.package(name: "swift-protobuf", path: "../")
.package(path: "../")
],
targets: [
.testTarget(
Expand Down