Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CI checkout directory from main to swift-protobuf and update tools version in PluginExamples Package.swift #1689

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

gjcairo
Copy link
Contributor

@gjcairo gjcairo commented Aug 12, 2024

SPM in 5.8 has trouble finding products when specifying a package name.
If the name argument is removed, it will default the package name to match the directory's name. In the checkout action, we check out the repo in a main directory, but we should rename it to swift-protobuf so it matches the Package's name and the package resolution works properly.

@gjcairo gjcairo requested a review from thomasvl August 12, 2024 19:29
@thomasvl thomasvl merged commit 259bf67 into apple:main Aug 12, 2024
10 checks passed
@gjcairo gjcairo deleted the plugin-examples-package branch August 13, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants