Disable ExistentialAny temporarily #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rather than just disable it everywhere, let's enable it in just the Swift 5.9+ builds, by adding This way we won't regress. |
What about adding a |
simonjbeaumont
approved these changes
Jul 17, 2023
simonjbeaumont
added a commit
that referenced
this pull request
Jan 16, 2024
…#46) ### Motivation When running the cancellation tests in a loop, very occasionally there would be a crash with the following backtrace: ``` #0 0x000000018aa008d4 in objc_opt_respondsToSelector () #1 0x000000018aea3410 in _outputStreamCallbackFunc () #2 0x000000018aea3310 in _signalEventSync () #3 0x000000018aeecdb0 in ___signalEventQueue_block_invoke () #4 0x000000018abe6cb8 in _dispatch_call_block_and_release () #5 0x000000018abe8910 in _dispatch_client_callout () #6 0x000000018abefea4 in _dispatch_lane_serial_drain () #7 0x000000018abf0a08 in _dispatch_lane_invoke () #8 0x000000018abfb61c in _dispatch_root_queue_drain_deferred_wlh () #9 0x000000018abfae90 in _dispatch_workloop_worker_thread () #10 0x000000018ad96114 in _pthread_wqthread () ``` This seems to indicate that the output stream is trying to access its delegate. However, when running with debug logging enabled I can see that the delegate has already been deinitialized. This is likely a result of the delegate itself owning the stream and setting the stream delegate to `self`, which IIUC is an established pattern. This presents a race in teardown. ### Modifications This patch sets the output stream delegate to `nil` in the delegate `deinit`. ### Result No attempts to call the delegate will happen after it is has been deinitailzed. ### Test Plan With this patch, the failing test passes when run an order of magnitude more times than were required to reliably reproduce the crash without the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Unfortunately until we adopt 5.9, adding ExistentialAny on upstream packages has unintended consequences for some downstream packages, so disabling for now. Details in apple/swift-openapi-generator#120
Modifications
Disabled the feature enforcement, but the code changes are there, so downstream adopters can still use them.
Result
We won't be seeing the issue described in apple/swift-openapi-generator#120.
Test Plan
PR CI, which discovered the original issue.