Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the ExistentialAny feature on all the repos for 5.8 #120

Closed
czechboy0 opened this issue Jul 17, 2023 · 2 comments
Closed

Disable the ExistentialAny feature on all the repos for 5.8 #120

czechboy0 opened this issue Jul 17, 2023 · 2 comments
Labels
area/generator Affects: plugin, CLI, config file. area/runtime Affects: the runtime library. area/transport Affects: Client or server transport library. size/S Small task. (A couple of hours of work.)

Comments

@czechboy0
Copy link
Contributor

Disable the ExistentialAny feature on all the repos temporarily.

See #119 for details, we just need to disable the enforcement temporarily.
@czechboy0 czechboy0 added area/generator Affects: plugin, CLI, config file. area/runtime Affects: the runtime library. area/transport Affects: Client or server transport library. size/S Small task. (A couple of hours of work.) labels Jul 17, 2023
This was referenced Jul 17, 2023
Merged
Merged
Merged
czechboy0 added a commit that referenced this issue Jul 17, 2023
@czechboy0
Disable ExistentialAny temporarily (#122)
32cd8a3 
Disable ExistentialAny temporarily

### Motivation

Unfortunately until we adopt 5.9, adding ExistentialAny on upstream packages has unintended consequences for some downstream packages, so disabling for now. Details in #120

### Modifications

Disabled the feature enforcement, but the code changes are there, so downstream adopters can still use them.

### Result

We won't be seeing the issue described in #120.

### Test Plan

PR CI, which discovered the original issue.


Reviewed by: simonjbeaumont

Builds:
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (docc test) - Build finished. 
     ✔︎ pull request validation (integration test) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 

#122
@czechboy0
Copy link
Contributor Author

We were able to only disable the feature for Swift 5.8, but keep it enabled on Swift 5.9+, so once we require 5.9, we can remove the conditional logic.

@czechboy0 czechboy0 changed the title Disable the ExistentialAny feature on all the repos temporarily Disable the ExistentialAny feature on all the repos for 5.8 Jul 17, 2023
czechboy0 added a commit to apple/swift-openapi-urlsession that referenced this issue Jul 17, 2023
@czechboy0
Disable ExistentialAny temporarily (#10)
f6e6c2f 
Disable ExistentialAny temporarily

### Motivation

Unfortunately until we adopt 5.9, adding ExistentialAny on upstream packages has unintended consequences for some downstream packages, so disabling for now. Details in apple/swift-openapi-generator#120

### Modifications

Disabled the feature enforcement, but the code changes are there, so downstream adopters can still use them.

### Result

We won't be seeing the issue described in apple/swift-openapi-generator#120.

### Test Plan

PR CI, which discovered the original issue.


Reviewed by: simonjbeaumont

Builds:
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 

#10
czechboy0 added a commit to swift-server/swift-openapi-async-http-client that referenced this issue Jul 17, 2023
@czechboy0
Disable ExistentialAny temporarily (#9)
875fecf 
Disable ExistentialAny temporarily

### Motivation

Unfortunately until we adopt 5.9, adding ExistentialAny on upstream packages has unintended consequences for some downstream packages, so disabling for now. Details in apple/swift-openapi-generator#120

### Modifications

Disabled the feature enforcement, but the code changes are there, so downstream adopters can still use them.

### Result

We won't be seeing the issue described in apple/swift-openapi-generator#120.

### Test Plan

PR CI, which discovered the original issue.


Reviewed by: simonjbeaumont

Builds:
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 

#9
@czechboy0
Copy link
Contributor Author

Ok this is done, we now only enable the feature enforcement on 5.9+.

@0xTim 0xTim mentioned this issue Jul 17, 2023
Closed
MahdiBM added a commit to MahdiBM/JWSETKit that referenced this issue Nov 21, 2023
@MahdiBM
disable existential-any on 5.8 due to a rare bug, per apple/swift-ope…
a07592e 
…napi-generator#120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/generator Affects: plugin, CLI, config file. area/runtime Affects: the runtime library. area/transport Affects: Client or server transport library. size/S Small task. (A couple of hours of work.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@czechboy0