Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Delete the original deprecated GreetingService examples #483

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

czechboy0
Copy link
Contributor

Motivation

Depends on #472 landing first.

Removes the original, now deprecated, GreetingService and GreetingServiceClient. We kept them here until close to 1.0 as pre-1.0 tutorials point to them.

Modifications

Deleted the examples, they're obsolete now and have been replaced by better examples.

Result

No more deprecated examples.

Test Plan

N/A

@czechboy0
Copy link
Contributor Author

@swift-server-bot compat-test-full

@simonjbeaumont
Copy link
Collaborator

Did you want to leave a symlink in place to the hello-world examples?

@czechboy0 czechboy0 marked this pull request as ready for review December 13, 2023 10:13
@czechboy0 czechboy0 merged commit 07367e8 into apple:main Dec 13, 2023
1 of 9 checks passed
@czechboy0 czechboy0 deleted the hd-delete-greeting-example branch December 13, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants