Prep 1.0: Bump versions #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@czechboy0 if this is going to be the final PR, shall we use this one to also remove the deprecated examples? Or—just had another thought—if there are links floating around to them in various places, should we add a symlink to the repo so folks land on the closest equivalent new example (and don't mention them explicitly in the |
|
Sure, that's a good idea. |
czechboy0
added a commit
that referenced
this pull request
Dec 12, 2023
### Motivation Our tutorials were originally written for SOAR 0.1.0, so we need to update them to reflect the best practices as of SOAR 1.0 instead. ### Modifications - Adapted to the new Examples structure (most importantly, point to cloning the Vapor hello world project when writing the client, instead of the GreetingService.) - Added a mention of the shorthand APIs as an alternative to the exhaustive handling. (Still show exhaustive handling first though, as we want to make sure adopters consider that first and even prefer it.) - More minor polish and updates. ### Result Tutorials ready for 1.0 (sans versions, those are changed in #472) ### Test Plan Previewed locally, actually went through all the tutorials and verified they all work.
|
Cloned this branch locally, tagged it locally, used git rewriting rules to run all the examples + integration tests locally, all passed. |
czechboy0
added a commit
that referenced
this pull request
Dec 13, 2023
) ### Motivation Depends on #472 landing first. Removes the original, now deprecated, GreetingService and GreetingServiceClient. We kept them here until close to 1.0 as pre-1.0 tutorials point to them. ### Modifications Deleted the examples, they're obsolete now and have been replaced by better examples. ### Result No more deprecated examples. ### Test Plan N/A --------- Co-authored-by: Si Beaumont <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Prep for 1.0.0.
Modifications
Bumped all 1.0.0-alpha.1 -> 1.0.0.
Result
Ready for 1.0.0 when it comes to versions.
Test Plan
Can't test yet.