Add an allocation test for execute which needs to hop threads. #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Feb 17, 2022
|
@glbrntt we are also missing |
glbrntt
approved these changes
Feb 17, 2022
Lukasa
approved these changes
Feb 17, 2022
Lukasa
added a commit
to Lukasa/swift-nio
that referenced
this pull request
Apr 26, 2023
Motivation This patch extends the NIO integration test harness to track file descriptors, in particular to search for leaks. This change has been validated on Linux and Darwin, and in both cases correctly diagnoses FD leaks. The goal is to enable us to regression test for things like Modifications - Add support for hooking socket and close calls. - Wire up this support into the test harness. - Extend the test harness to handle the logging. - Add new regression test for apple#2047. Results We can write regression tests for FD leaks.
Lukasa
added a commit
that referenced
this pull request
Apr 26, 2023
* Extend the integration test harness to track FDs Motivation This patch extends the NIO integration test harness to track file descriptors, in particular to search for leaks. This change has been validated on Linux and Darwin, and in both cases correctly diagnoses FD leaks. The goal is to enable us to regression test for things like Modifications - Add support for hooking socket and close calls. - Wire up this support into the test harness. - Extend the test harness to handle the logging. - Add new regression test for #2047. Results We can write regression tests for FD leaks. * Disable FD checking in most builds. I'm doing this for speed reasons * Always print the leaked fds number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of allocation tests around scheduling tasks. However we have calls execute on an
EventLoopthat we are not executing on.Motivation:
executeis, if we are of theEventLoop.Modifications:
Result:
The more allocation knowledge, the better to optimize.